From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super
Date: Thu, 29 Jan 2015 19:24:59 +0800 [thread overview]
Message-ID: <002a01d03bb6$530c8340$f92589c0$@samsung.com> (raw)
In-Reply-To: <1422401503-4769-1-git-send-email-jaegeuk@kernel.org>
Hi Jaegeuk,
> -----Original Message-----
> From: linux-fsdevel-owner@vger.kernel.org [mailto:linux-fsdevel-owner@vger.kernel.org] On
> Behalf Of Jaegeuk Kim
> Sent: Wednesday, January 28, 2015 7:32 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super
>
> If wrong mount option was requested, f2fs tries to fill_super again.
> But, during the next trial, f2fs has no valid mount options, since
> parse_options deleted all the separators in the original string.
Nice catch!
But couldn't we encounter memory leak for options if we did not fail to fill super.
Thanks,
next prev parent reply other threads:[~2015-01-29 11:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 23:31 [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super Jaegeuk Kim
2015-01-27 23:31 ` [PATCH 2/5] f2fs: support norecovery mount option Jaegeuk Kim
2015-01-29 11:52 ` Chao Yu
2015-01-29 18:27 ` Jaegeuk Kim
2015-01-29 18:31 ` [f2fs-dev] [PATCH 2/5 v2] " Jaegeuk Kim
2015-01-30 5:11 ` Chao Yu
2015-01-30 5:10 ` [PATCH 2/5] " Chao Yu
2015-01-27 23:31 ` [PATCH 3/5] f2fs: avoid write_checkpoint if f2fs is mounted readonly Jaegeuk Kim
2015-01-29 11:55 ` Chao Yu
2015-01-27 23:31 ` [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev Jaegeuk Kim
2015-01-29 12:16 ` Chao Yu
2015-01-29 21:39 ` Jaegeuk Kim
2015-01-30 5:12 ` Chao Yu
2015-01-30 5:15 ` Chao Yu
2015-01-27 23:31 ` [PATCH 5/5] f2fs: introduce a batched trim Jaegeuk Kim
2015-01-29 12:38 ` Chao Yu
2015-01-29 21:41 ` Jaegeuk Kim
2015-01-30 5:13 ` Chao Yu
2015-02-02 23:29 ` [PATCH 5/5 v2] " Jaegeuk Kim
2015-02-03 2:48 ` [f2fs-dev] " Changman Lee
2015-02-03 20:10 ` [f2fs-dev] [PATCH 5/5 v3] " Jaegeuk Kim
2015-02-05 9:30 ` Chao Yu
2015-02-06 6:18 ` [f2fs-dev] [PATCH 5/5 v4] " Jaegeuk Kim
2015-02-06 8:20 ` Chao Yu
2015-02-07 15:57 ` Leon Romanovsky
2015-02-09 7:04 ` Jaegeuk Kim
2015-01-29 11:24 ` Chao Yu [this message]
2015-01-29 18:21 ` [PATCH 1/5 v2] f2fs: fix not to drop mount options when retrying fill_super Jaegeuk Kim
2015-01-30 5:02 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002a01d03bb6$530c8340$f92589c0$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox