From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 5/5] f2fs: introduce a batched trim
Date: Tue, 27 Jan 2015 15:31:43 -0800 [thread overview]
Message-ID: <1422401503-4769-5-git-send-email-jaegeuk@kernel.org> (raw)
In-Reply-To: <1422401503-4769-1-git-send-email-jaegeuk@kernel.org>
This patch introduces a batched trimming feature, which submits split discard
commands.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/segment.c | 15 ++++++++++-----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index c0b83d6..ec4d16b 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -104,6 +104,7 @@ enum {
CP_DISCARD,
};
+#define BATCHED_TRIM_SEGMENTS 10
struct cp_control {
int reason;
__u64 trim_start;
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 31c4e57..6c9c784 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1066,14 +1066,19 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range)
end_segno = (end >= MAX_BLKADDR(sbi)) ? MAIN_SEGS(sbi) - 1 :
GET_SEGNO(sbi, end);
cpc.reason = CP_DISCARD;
- cpc.trim_start = start_segno;
- cpc.trim_end = end_segno;
cpc.trim_minlen = range->minlen >> sbi->log_blocksize;
/* do checkpoint to issue discard commands safely */
- mutex_lock(&sbi->gc_mutex);
- write_checkpoint(sbi, &cpc);
- mutex_unlock(&sbi->gc_mutex);
+ for (; start_segno <= end_segno;
+ start_segno += BATCHED_TRIM_SEGMENTS + 1) {
+ cpc.trim_start = start_segno;
+ cpc.trim_end = min_t(unsigned int,
+ start_segno + BATCHED_TRIM_SEGMENTS, end_segno);
+
+ mutex_lock(&sbi->gc_mutex);
+ write_checkpoint(sbi, &cpc);
+ mutex_unlock(&sbi->gc_mutex);
+ }
out:
range->len = cpc.trimmed << sbi->log_blocksize;
return 0;
--
2.1.1
next prev parent reply other threads:[~2015-01-27 23:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 23:31 [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super Jaegeuk Kim
2015-01-27 23:31 ` [PATCH 2/5] f2fs: support norecovery mount option Jaegeuk Kim
2015-01-29 11:52 ` Chao Yu
2015-01-29 18:27 ` Jaegeuk Kim
2015-01-29 18:31 ` [f2fs-dev] [PATCH 2/5 v2] " Jaegeuk Kim
2015-01-30 5:11 ` Chao Yu
2015-01-30 5:10 ` [PATCH 2/5] " Chao Yu
2015-01-27 23:31 ` [PATCH 3/5] f2fs: avoid write_checkpoint if f2fs is mounted readonly Jaegeuk Kim
2015-01-29 11:55 ` Chao Yu
2015-01-27 23:31 ` [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev Jaegeuk Kim
2015-01-29 12:16 ` Chao Yu
2015-01-29 21:39 ` Jaegeuk Kim
2015-01-30 5:12 ` Chao Yu
2015-01-30 5:15 ` Chao Yu
2015-01-27 23:31 ` Jaegeuk Kim [this message]
2015-01-29 12:38 ` [PATCH 5/5] f2fs: introduce a batched trim Chao Yu
2015-01-29 21:41 ` Jaegeuk Kim
2015-01-30 5:13 ` Chao Yu
2015-02-02 23:29 ` [PATCH 5/5 v2] " Jaegeuk Kim
2015-02-03 2:48 ` [f2fs-dev] " Changman Lee
2015-02-03 20:10 ` [f2fs-dev] [PATCH 5/5 v3] " Jaegeuk Kim
2015-02-05 9:30 ` Chao Yu
2015-02-06 6:18 ` [f2fs-dev] [PATCH 5/5 v4] " Jaegeuk Kim
2015-02-06 8:20 ` Chao Yu
2015-02-07 15:57 ` Leon Romanovsky
2015-02-09 7:04 ` Jaegeuk Kim
2015-01-29 11:24 ` [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super Chao Yu
2015-01-29 18:21 ` [PATCH 1/5 v2] " Jaegeuk Kim
2015-01-30 5:02 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422401503-4769-5-git-send-email-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox