* [PATCH 2/2] misc: ep93xx_pwm: remove unnecessary platform_set_drvdata()
@ 2013-05-07 5:34 Jingoo Han
2013-05-14 0:49 ` H Hartley Sweeten
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 5:34 UTC (permalink / raw)
To: 'Arnd Bergmann', 'Greg Kroah-Hartman'
Cc: linux-kernel, 'Hartley Sweeten', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/misc/ep93xx_pwm.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/ep93xx_pwm.c b/drivers/misc/ep93xx_pwm.c
index 96787ec..9ba93f0 100644
--- a/drivers/misc/ep93xx_pwm.c
+++ b/drivers/misc/ep93xx_pwm.c
@@ -347,7 +347,6 @@ static int __exit ep93xx_pwm_remove(struct platform_device *pdev)
ep93xx_pwm_disable(pwm);
clk_disable(pwm->clk);
clk_put(pwm->clk);
- platform_set_drvdata(pdev, NULL);
sysfs_remove_group(&pdev->dev.kobj, &ep93xx_pwm_sysfs_files);
iounmap(pwm->mmio_base);
release_mem_region(res->start, resource_size(res));
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 2/2] misc: ep93xx_pwm: remove unnecessary platform_set_drvdata()
2013-05-07 5:34 [PATCH 2/2] misc: ep93xx_pwm: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-14 0:49 ` H Hartley Sweeten
0 siblings, 0 replies; 2+ messages in thread
From: H Hartley Sweeten @ 2013-05-14 0:49 UTC (permalink / raw)
To: Jingoo Han, 'Arnd Bergmann', 'Greg Kroah-Hartman'
Cc: linux-kernel@vger.kernel.org
On Monday, May 06, 2013 10:34 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/misc/ep93xx_pwm.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 0:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 5:34 [PATCH 2/2] misc: ep93xx_pwm: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-14 0:49 ` H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox