From: Jingoo Han <jg1.han@samsung.com>
To: linux-kernel@vger.kernel.org
Cc: "'Bryan Wu'" <cooloney@gmail.com>,
"'Lee Jones'" <lee.jones@linaro.org>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH V2 04/18] backlight: ams369fg06: remove 'else' after a return
Date: Wed, 27 Aug 2014 10:10:34 +0900 [thread overview]
Message-ID: <004801cfc193$b449ea50$1cddbef0$%han@samsung.com> (raw)
In-Reply-To: <004301cfc193$69c1de20$3d459a60$%han@samsung.com>
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
drivers/video/backlight/ams369fg06.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/ams369fg06.c b/drivers/video/backlight/ams369fg06.c
index 4726c8be626f..5f897f99cc9b 100644
--- a/drivers/video/backlight/ams369fg06.c
+++ b/drivers/video/backlight/ams369fg06.c
@@ -325,11 +325,11 @@ static int ams369fg06_power_on(struct ams369fg06 *lcd)
if (!pd->reset) {
dev_err(lcd->dev, "reset is NULL.\n");
return -EINVAL;
- } else {
- pd->reset(lcd->ld);
- msleep(pd->reset_delay);
}
+ pd->reset(lcd->ld);
+ msleep(pd->reset_delay);
+
ret = ams369fg06_ldi_init(lcd);
if (ret) {
dev_err(lcd->dev, "failed to initialize ldi.\n");
--
2.0.0
next prev parent reply other threads:[~2014-08-27 1:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 1:08 [PATCH V2 00/18] backlight: fix checkpatch warnings Jingoo Han
2014-08-27 1:09 ` [PATCH V2 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
2014-08-27 1:09 ` [PATCH V2 02/18] backlight: adp8860: " Jingoo Han
2014-08-27 1:10 ` [PATCH V2 03/18] backlight: adp8870: " Jingoo Han
2014-08-27 1:10 ` Jingoo Han [this message]
2014-08-27 1:10 ` [PATCH V2 05/18] backlight: corgi_lcd: " Jingoo Han
2014-08-27 1:11 ` [PATCH V2 06/18] backlight: cr_bllcd: " Jingoo Han
2014-08-27 1:11 ` [PATCH V2 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
2014-08-27 1:11 ` [PATCH V2 08/18] backlight: ld9040: " Jingoo Han
2014-08-27 1:12 ` [PATCH V2 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
2014-08-27 1:12 ` [PATCH V2 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
2014-08-27 1:12 ` [PATCH V2 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
2014-08-27 1:13 ` [PATCH V2 12/18] backlight: pcf50633: " Jingoo Han
2014-08-27 1:13 ` [PATCH V2 13/18] backlight: s6e63m0: remove 'else' after a return Jingoo Han
2014-08-27 1:13 ` [PATCH V2 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
2014-08-27 1:14 ` [PATCH V2 15/18] backlight: wm831x_bl: " Jingoo Han
2014-08-27 1:14 ` [PATCH V2 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
2014-08-27 1:14 ` [PATCH V2 17/18] " Jingoo Han
2014-08-27 1:15 ` [PATCH V2 18/18] backlight: omap1: add blank line after declarations Jingoo Han
2014-08-27 7:14 ` [PATCH V2 00/18] backlight: fix checkpatch warnings Lee Jones
2014-08-29 7:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004801cfc193$b449ea50$1cddbef0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=cooloney@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox