From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-kernel@vger.kernel.org, "'Bryan Wu'" <cooloney@gmail.com>
Subject: Re: [PATCH V2 00/18] backlight: fix checkpatch warnings
Date: Fri, 29 Aug 2014 08:30:17 +0100 [thread overview]
Message-ID: <20140829073017.GB24579@lee--X1> (raw)
In-Reply-To: <20140827071402.GX26707@lee--X1>
On Wed, 27 Aug 2014, Lee Jones wrote:
> On Wed, 27 Aug 2014, Jingoo Han wrote:
> > This patchset fixes checkpatch warnings as follows.
> > There is no functional change.
> >
> > WARNING: Missing a blank line after declarations
> > WARNING: else is not generally useful after a break or return
> > WARNING: void function return statements are not generally useful
> >
> > Changes for V2
> > - Added Lee Jones's Acked-by for 1~18th patches, except for 17th patch.
> > - Fixed 17th patch, per Lee Jones's feedback.
> >
> > Jingoo Han (18)
> > backlight: adp5520: add blank line after declarations
> > backlight: adp8860: add blank line after declarations
> > backlight: adp8870: add blank line after declarations
> > backlight: ams369fg06: remove 'else' after a return
> > backlight: corgi_lcd: add blank line after declarations
> > backlight: cr_bllcd: add blank line after declarations
> > backlight: ili922x: remove 'else' after a return
> > backlight: ld9040: remove 'else' after a return
> > backlight: lm3639: remove unnecessary return statements
> > backlight: lms501kf03: remove 'else' after a return
> > backlight: lp855x: add blank line after declarations
> > backlight: pcf50633: add blank line after declarations
> > backlight: s6e63m0: remove 'else' after a return
> > backlight: tdo24m: add blank line after declarations
> > backlight: wm831x_bl: add blank line after declarations
> > backlight: jornada720: remove 'else' after a return
> > backlight: jornada720: remove 'else' after a return
> > backlight: omap1: add blank line after declarations
>
> I'll wait to see if Bryan has anything to add. If not, I'll apply
> them in a couple of days.
All patches applied and pushed.
> > ---
> > drivers/video/backlight/adp5520_bl.c | 1 +
> > drivers/video/backlight/adp8860_bl.c | 3 +++
> > drivers/video/backlight/adp8870_bl.c | 4 ++++
> > drivers/video/backlight/ams369fg06.c | 6 +++---
> > drivers/video/backlight/corgi_lcd.c | 1 +
> > drivers/video/backlight/cr_bllcd.c | 1 +
> > drivers/video/backlight/ili922x.c | 11 ++++++-----
> > drivers/video/backlight/jornada720_bl.c | 6 +++---
> > drivers/video/backlight/jornada720_lcd.c | 6 +-----
> > drivers/video/backlight/ld9040.c | 6 +++---
> > drivers/video/backlight/lm3639_bl.c | 2 --
> > drivers/video/backlight/lms501kf03.c | 12 ++++++------
> > drivers/video/backlight/lp855x_bl.c | 2 ++
> > drivers/video/backlight/omap1_bl.c | 1 +
> > drivers/video/backlight/pcf50633-backlight.c | 1 +
> > drivers/video/backlight/s6e63m0.c | 12 ++++++------
> > drivers/video/backlight/tdo24m.c | 2 ++
> > drivers/video/backlight/wm831x_bl.c | 1 +
> > 18 files changed, 45 insertions(+), 33 deletions(-)
> >
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-08-29 7:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 1:08 [PATCH V2 00/18] backlight: fix checkpatch warnings Jingoo Han
2014-08-27 1:09 ` [PATCH V2 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
2014-08-27 1:09 ` [PATCH V2 02/18] backlight: adp8860: " Jingoo Han
2014-08-27 1:10 ` [PATCH V2 03/18] backlight: adp8870: " Jingoo Han
2014-08-27 1:10 ` [PATCH V2 04/18] backlight: ams369fg06: remove 'else' after a return Jingoo Han
2014-08-27 1:10 ` [PATCH V2 05/18] backlight: corgi_lcd: add blank line after declarations Jingoo Han
2014-08-27 1:11 ` [PATCH V2 06/18] backlight: cr_bllcd: " Jingoo Han
2014-08-27 1:11 ` [PATCH V2 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
2014-08-27 1:11 ` [PATCH V2 08/18] backlight: ld9040: " Jingoo Han
2014-08-27 1:12 ` [PATCH V2 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
2014-08-27 1:12 ` [PATCH V2 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
2014-08-27 1:12 ` [PATCH V2 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
2014-08-27 1:13 ` [PATCH V2 12/18] backlight: pcf50633: " Jingoo Han
2014-08-27 1:13 ` [PATCH V2 13/18] backlight: s6e63m0: remove 'else' after a return Jingoo Han
2014-08-27 1:13 ` [PATCH V2 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
2014-08-27 1:14 ` [PATCH V2 15/18] backlight: wm831x_bl: " Jingoo Han
2014-08-27 1:14 ` [PATCH V2 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
2014-08-27 1:14 ` [PATCH V2 17/18] " Jingoo Han
2014-08-27 1:15 ` [PATCH V2 18/18] backlight: omap1: add blank line after declarations Jingoo Han
2014-08-27 7:14 ` [PATCH V2 00/18] backlight: fix checkpatch warnings Lee Jones
2014-08-29 7:30 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829073017.GB24579@lee--X1 \
--to=lee.jones@linaro.org \
--cc=cooloney@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox