linux-next: incorrect build fix

linux-next: incorrect build fix

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi,

I noticed in commit 8644c202ff42 ("ARM: EXYNOS: Fix compiler error with
THIS_MODULE") in the s5p tree, an include of linux/module.h is used to
get THIS_MODULE. For THIS_MODULE, you only need to include
linux/export.h, now.  To fix the other errors that were fixed by side
effects of including module.h, you should include linux/time.h (for
struct timeval, USEC_PER_SEC and do_gettimeofday).

Please try a bit harder to get these things right.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: incorrect build fix

[Kukjin Kim]

Stephen Rothwell wrote:
> 
> Hi,
> 
Hi Stephen,

> I noticed in commit 8644c202ff42 ("ARM: EXYNOS: Fix compiler error with
> THIS_MODULE") in the s5p tree, an include of linux/module.h is used to
> get THIS_MODULE. For THIS_MODULE, you only need to include
> linux/export.h, now.  To fix the other errors that were fixed by side
> effects of including module.h, you should include linux/time.h (for
> struct timeval, USEC_PER_SEC and do_gettimeofday).
> 
OK, I will fix it in my tree.

> Please try a bit harder to get these things right.

Thanks for your pointing out :)

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

RE: linux-next: incorrect build fix

[Kukjin Kim]

Kukjin Kim wrote:
> 
> Stephen Rothwell wrote:
> >
> > Hi,
> >
> Hi Stephen,
> 
> > I noticed in commit 8644c202ff42 ("ARM: EXYNOS: Fix compiler error with
> > THIS_MODULE") in the s5p tree, an include of linux/module.h is used to
> > get THIS_MODULE. For THIS_MODULE, you only need to include
> > linux/export.h, now.  To fix the other errors that were fixed by side
> > effects of including module.h, you should include linux/time.h (for
> > struct timeval, USEC_PER_SEC and do_gettimeofday).
> >
> OK, I will fix it in my tree.
> 
> > Please try a bit harder to get these things right.
> 
Stephen,

I'm not sure following......
So only for THIS_MODULE, <linux/export.h> should be added instead of
<linux/module.h>?

> Thanks for your pointing out :)
> 

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: linux-next: incorrect build fix

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Hi,

On Wed, 09 Nov 2011 15:11:50 +0900 Kukjin Kim <kgene.kim@samsung.com> wrote:
>
> I'm not sure following......
> So only for THIS_MODULE, <linux/export.h> should be added instead of
> <linux/module.h>?

Yes, that is correct.   It means that much less code is included.  If
replacing module.h with export.h causes other build errors, they should
be fixed by including the correct files directly (module.h include a lot
of other include files).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: incorrect build fix

[Kukjin Kim]

Stephen Rothwell wrote:
> 
> Hi,
> 
> On Wed, 09 Nov 2011 15:11:50 +0900 Kukjin Kim <kgene.kim@samsung.com>
> wrote:
> >
> > I'm not sure following......
> > So only for THIS_MODULE, <linux/export.h> should be added instead of
> > <linux/module.h>?
> 
> Yes, that is correct.   It means that much less code is included.  If
> replacing module.h with export.h causes other build errors, they should
> be fixed by including the correct files directly (module.h include a lot
> of other include files).

I agree, okay. Will update Samsung stuff :)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.