* [PATCH] w1: matrox: use DEFINE_PCI_DEVICE_TABLE macro @ 2013-11-28 3:45 Jingoo Han 2013-11-28 4:40 ` Jingoo Han 0 siblings, 1 reply; 3+ messages in thread From: Jingoo Han @ 2013-11-28 3:45 UTC (permalink / raw) To: 'Andrew Morton' Cc: linux-kernel, 'Evgeniy Polyakov', 'Jingoo Han' This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/w1/masters/matrox_w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index d8667b0..9361cea 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -42,7 +42,7 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Evgeniy Polyakov <zbr@ioremap.net>"); MODULE_DESCRIPTION("Driver for transport(Dallas 1-wire prtocol) over VGA DDC(matrox gpio)."); -static struct pci_device_id matrox_w1_tbl[] = { +static DEFINE_PCI_DEVICE_TABLE(matrox_w1_tbl) = { { PCI_DEVICE(PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G400) }, { }, }; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: matrox: use DEFINE_PCI_DEVICE_TABLE macro 2013-11-28 3:45 [PATCH] w1: matrox: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han @ 2013-11-28 4:40 ` Jingoo Han 2013-11-28 16:24 ` Рустафа Джамурахметов 0 siblings, 1 reply; 3+ messages in thread From: Jingoo Han @ 2013-11-28 4:40 UTC (permalink / raw) To: 'Andrew Morton' Cc: linux-kernel, 'Evgeniy Polyakov', 'Jingoo Han' On Thursday, November 28, 2013 12:46 PM, Jingoo Han wrote: > > This macro is used to create a struct pci_device_id array. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Please, ignore these patches. According to the Greg Kroah-Hartman, "Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places. Actually, if you could just remove it, that would be best, sorry, I'm not going to take these patches." So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. Sorry for annoying. :-) Best regards, Jingoo Han > --- > drivers/w1/masters/matrox_w1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c > index d8667b0..9361cea 100644 > --- a/drivers/w1/masters/matrox_w1.c > +++ b/drivers/w1/masters/matrox_w1.c > @@ -42,7 +42,7 @@ MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Evgeniy Polyakov <zbr@ioremap.net>"); > MODULE_DESCRIPTION("Driver for transport(Dallas 1-wire prtocol) over VGA DDC(matrox gpio)."); > > -static struct pci_device_id matrox_w1_tbl[] = { > +static DEFINE_PCI_DEVICE_TABLE(matrox_w1_tbl) = { > { PCI_DEVICE(PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G400) }, > { }, > }; > -- > 1.7.10.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: matrox: use DEFINE_PCI_DEVICE_TABLE macro 2013-11-28 4:40 ` Jingoo Han @ 2013-11-28 16:24 ` Рустафа Джамурахметов 0 siblings, 0 replies; 3+ messages in thread From: Рустафа Джамурахметов @ 2013-11-28 16:24 UTC (permalink / raw) To: Jingoo Han, 'Andrew Morton'; +Cc: linux-kernel@vger.kernel.org Hi 28.11.2013, 08:40, "Jingoo Han" <jg1.han@samsung.com>: > "Yeah, and it's a horrid macro that deserves to be removed, please don't > use it in more places. > > Actually, if you could just remove it, that would be best, sorry, I'm > not going to take these patches." > > So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. > Sorry for annoying. :-) No problem :) Thanks for noticing this issue ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-28 16:24 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-28 3:45 [PATCH] w1: matrox: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han 2013-11-28 4:40 ` Jingoo Han 2013-11-28 16:24 ` Рустафа Джамурахметов
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox