From: Jie Luo <quic_luoj@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<quic_kkumarcs@quicinc.com>, <quic_suruchia@quicinc.com>,
<quic_pavir@quicinc.com>, <quic_linchen@quicinc.com>,
<quic_leiwei@quicinc.com>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: Add common PLL node for IPQ9574 SoC
Date: Fri, 9 Aug 2024 19:23:23 +0800 [thread overview]
Message-ID: <00960663-00a4-4662-9792-7899fc6ce101@quicinc.com> (raw)
In-Reply-To: <1d5b1666-4ced-45e6-bea4-50a33530a12c@kernel.org>
On 8/8/2024 10:45 PM, Krzysztof Kozlowski wrote:
> On 08/08/2024 16:03, Luo Jie wrote:
>
>>
>> /dts-v1/;
>> @@ -167,3 +167,7 @@ &usb3 {
>> &xo_board_clk {
>> clock-frequency = <24000000>;
>> };
>> +
>> +&cmn_pll_ref_clk {
>
> Please follow DTS coding style.
Ok. Thanks for pointing to this. I will move &cmn_pll_ref_clk before
&xo_board_clk to make the DTS ordering alpha-numerical by the node name.
>
>> + clock-frequency = <48000000>;
>> +};
>
>
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2024-08-09 11:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 14:03 [PATCH 0/4] Add common PLL clock controller driver for IPQ9574 Luo Jie
2024-08-08 14:03 ` [PATCH 1/4] dt-bindings: clock: qcom: Add common PLL clock controller for IPQ SoC Luo Jie
2024-08-08 14:38 ` Krzysztof Kozlowski
2024-08-09 13:01 ` Jie Luo
2024-08-10 11:30 ` Krzysztof Kozlowski
2024-08-14 15:13 ` Jie Luo
2024-08-08 14:03 ` [PATCH 2/4] clk: qcom: Add common PLL clock controller driver " Luo Jie
2024-08-10 23:53 ` kernel test robot
2024-08-08 14:03 ` [PATCH 3/4] arm64: defconfig: Enable Qualcomm IPQ common PLL clock controller Luo Jie
2024-08-08 14:41 ` Krzysztof Kozlowski
2024-08-09 11:36 ` Jie Luo
2024-08-09 13:34 ` Andrew Lunn
2024-08-13 12:07 ` Jie Luo
2024-08-08 14:03 ` [PATCH 4/4] arm64: dts: qcom: Add common PLL node for IPQ9574 SoC Luo Jie
2024-08-08 14:45 ` Krzysztof Kozlowski
2024-08-09 11:23 ` Jie Luo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00960663-00a4-4662-9792-7899fc6ce101@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox