public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Christian Loehle <christian.loehle@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	Aboorva Devarajan <aboorvad@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v1 1/4] cpuidle: teo: Add polling flag check to early return path
Date: Thu, 23 Jan 2025 18:54:33 +0200	[thread overview]
Message-ID: <00fffcc11f41ffd069c499010e89244d4ccb6cec.camel@gmail.com> (raw)
In-Reply-To: <842b1500-9f4f-47e5-9777-ee89351f956e@arm.com>

On Fri, 2025-01-10 at 13:16 +0000, Christian Loehle wrote:
> This would then enable intercept-detection only for <50% of the time,
> another option is to not allow intercepts selecting a polling state, but
> there were recent complaints about this exact behavior from Aboorva (+TO).
> They don't have a low-latency non-polling state.

What folks think about the following idea.

Idle governor algorithm essentially predicts the sleep time (step 1), based on
that, the idle state gets selected (step 2).

What if we add a sleep time factor and expose it via sysfs. The predicted sleep
time would be multiplied by the factor (between steps 1 and 2).

Default factor value is 1 (or 100%). If users want teo be more hesitant
selecting deeper idle states, they can set it to 0.5 (or 50%) or some other
value < 1. I users want teo to be more enthusiastic about selecting deeper idle
states, they set the factor to a value > 1.

We could expose it via sysfs and allow changing in some reasonable range.

The idea is to let users adjust the level of idle governor (teo in this case)
enthusiasm regarding deep C-state.

Thanks,
Artem.

  parent reply	other threads:[~2025-01-23 16:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 12:51 [PATCH v1 0/4] cpuidle: teo: Fix and cleanups Rafael J. Wysocki
2025-01-10 12:53 ` [PATCH v1 1/4] cpuidle: teo: Add polling flag check to early return path Rafael J. Wysocki
2025-01-10 13:16   ` Christian Loehle
2025-01-10 13:34     ` Rafael J. Wysocki
2025-01-10 14:52       ` Christian Loehle
2025-01-10 15:17         ` Rafael J. Wysocki
2025-01-10 17:23         ` Rafael J. Wysocki
2025-01-23 16:54     ` Artem Bityutskiy [this message]
2025-01-23 18:12       ` Rafael J. Wysocki
2025-01-10 12:54 ` [PATCH v1 2/4] cpuidle: teo: Rearrange idle state lookup code Rafael J. Wysocki
2025-01-10 12:55 ` [PATCH v1 3/4] cpuidle: teo: Reorder candidate state index checks Rafael J. Wysocki
2025-01-10 12:56 ` [PATCH v1 4/4] cpuidle: teo: Combine candidate state index checks against 0 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00fffcc11f41ffd069c499010e89244d4ccb6cec.camel@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=aboorvad@linux.ibm.com \
    --cc=christian.loehle@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox