The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] Fix vesafb with large memory, this time properly
@ 2003-05-15 22:49 Adam Mercer
  2003-05-15 22:58 ` Fred Garvin
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Mercer @ 2003-05-15 22:49 UTC (permalink / raw)
  To: marcelo; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Marcelo

Thanks for apply my previous patch, but Geert Uytterhoeven noticed the
following problem with it

> video_size must be in bytes, hence it must be
> 
> video_size = screen_info.lfb_width*screen_info.lfb_height*video_bpp/8;

The attached patch, against 2.4.21-rc2, fixes this

Cheers

Adam

[-- Attachment #2: 2.4.21-rc2-vesafb.patch --]
[-- Type: text/plain, Size: 691 bytes --]

diff -urN linux-2.4.21-rc2/drivers/video/vesafb.c linux-2.4.21-rc2-patched/drivers/video/vesafb.c
--- linux-2.4.21-rc2/drivers/video/vesafb.c	2003-05-15 07:42:55.000000000 +0100
+++ linux-2.4.21-rc2-patched/drivers/video/vesafb.c	2003-05-15 07:39:53.000000000 +0100
@@ -520,7 +520,7 @@
 	video_width         = screen_info.lfb_width;
 	video_height        = screen_info.lfb_height;
 	video_linelength    = screen_info.lfb_linelength;
-	video_size          = screen_info.lfb_width *	screen_info.lfb_height * video_bpp;
+	video_size          = screen_info.lfb_width *	screen_info.lfb_height * video_bpp / 8;
 	video_visual = (video_bpp == 8) ?
 		FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_TRUECOLOR;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix vesafb with large memory, this time properly
  2003-05-15 22:49 [PATCH] Fix vesafb with large memory, this time properly Adam Mercer
@ 2003-05-15 22:58 ` Fred Garvin
  0 siblings, 0 replies; 2+ messages in thread
From: Fred Garvin @ 2003-05-15 22:58 UTC (permalink / raw)
  To: linux-kernel

> Thanks for apply my previous patch, but Geert Uytterhoeven noticed the
> following problem with it
>
> > video_size must be in bytes, hence it must be
> >
> > video_size = screen_info.lfb_width*screen_info.lfb_height*video_bpp/8;
>
> The attached patch, against 2.4.21-rc2, fixes this

  Thanks for fixing this.

Fred


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-05-15 22:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-15 22:49 [PATCH] Fix vesafb with large memory, this time properly Adam Mercer
2003-05-15 22:58 ` Fred Garvin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox