From: Ashish Mhetre <amhetre@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] iommu/arm-smmu-v3: Factor out CMDQ batch force-sync conditions
Date: Fri, 10 Jul 2026 12:09:08 +0530 [thread overview]
Message-ID: <014ae844-e7ca-4829-95f6-31de979db140@nvidia.com> (raw)
In-Reply-To: <alB0/RXGUtoyXggd@nvidia.com>
On 7/10/2026 9:58 AM, Nicolin Chen wrote:
> On Thu, Jul 09, 2026 at 09:56:07AM +0000, Ashish Mhetre wrote:
>> From: Nicolin Chen <nicolinc@nvidia.com>
>>
>> arm_smmu_cmdq_batch_add_cmd_p() carries two distinct reasons for
>> flushing the current batch with a CMD_SYNC before appending the
>> new command:
>>
>> - The batch's pre-assigned cmdq does not support the new command.
>> - The Arm erratum 2812531 workaround (ARM_SMMU_OPT_CMDQ_FORCE_SYNC)
>> forces a SYNC at one entry before the batch is full.
>>
>> Lift those checks into a new arm_smmu_cmdq_batch_force_sync() helper
>> so that adding another force-sync condition becomes a one-line
>> addition. No functional change.
> Patch is fine, but you're missing the cover-letter and changelogs.
>
> Nicolin
I had sent out the cover-letter along with change logs.
The sequence got messed up while sending. Here's the cover letter.
https://lore.kernel.org/linux-tegra/20260709095613.831769-4-amhetre@nvidia.com/T/#u
I will fix this in next version.
Thanks,
Ashish Mhetre
prev parent reply other threads:[~2026-07-10 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 9:56 [PATCH v5 1/3] iommu/arm-smmu-v3: Factor out CMDQ batch force-sync conditions Ashish Mhetre
2026-07-09 9:56 ` [PATCH v5 2/3] iommu/arm-smmu-v3: Introduce CFGI/TLBI-repeat workaround infrastructure Ashish Mhetre
2026-07-10 4:20 ` Nicolin Chen
2026-07-10 6:35 ` Ashish Mhetre
2026-07-09 9:56 ` [PATCH v5 3/3] iommu/arm-smmu-v3: Enable CFGI/TLBI-repeat workaround on Tegra264 Ashish Mhetre
2026-07-10 4:25 ` Nicolin Chen
2026-07-10 6:36 ` Ashish Mhetre
2026-07-10 4:28 ` [PATCH v5 1/3] iommu/arm-smmu-v3: Factor out CMDQ batch force-sync conditions Nicolin Chen
2026-07-10 6:39 ` Ashish Mhetre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=014ae844-e7ca-4829-95f6-31de979db140@nvidia.com \
--to=amhetre@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox