min() and max() in kernel.h ?

min() and max() in kernel.h ?

[Herbert Rosmanith]

hi,

just now I tried to compile some module and noticed that it doesnt
compile anymore because "macro min used with only two arguments".
I had some "#define min(a,b) (a<b?a:b)" myself.

I then found min() being defined in <linux/kernel.h> with an additional
type argument and some superfluos (imo) assignment code. Erm. What's going
next, drawing elipses in kernel?

I'm also missing some comment who added min/max to kernel.h, at least
I want to know who I am going to flame :->

/herp

Re: min() and max() in kernel.h ?

[Michael H. Warfield]

On Fri, Aug 17, 2001 at 09:13:20PM +0200, Herbert Rosmanith wrote:

> hi,

> just now I tried to compile some module and noticed that it doesnt
> compile anymore because "macro min used with only two arguments".
> I had some "#define min(a,b) (a<b?a:b)" myself.

> I then found min() being defined in <linux/kernel.h> with an additional
> type argument and some superfluos (imo) assignment code. Erm. What's going
> next, drawing elipses in kernel?

> I'm also missing some comment who added min/max to kernel.h, at least
> I want to know who I am going to flame :->

	Please review the flamefest threads in this forum going under the
subjects of "2.4.9 does not compile" and related "[PATCH]".  That will
answer who what when and why, as well as giving you a suitable case of
characters to throw stones, or whatever else is handy, at.

	Rather interesting that Linus ducked out of town just in time
for this...  :->

> /herp

	Mike
-- 
 Michael H. Warfield    |  (770) 985-6132   |  mhw@WittsEnd.com
  (The Mad Wizard)      |  (678) 463-0932   |  http://www.wittsend.com/mhw/
  NIC whois:  MHW9      |  An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!

Re: min() and max() in kernel.h ?

[Jeff Golds]

"Michael H. Warfield" wrote:
> 
>         Please review the flamefest threads in this forum going under the
> subjects of "2.4.9 does not compile" and related "[PATCH]".  That will
> answer who what when and why, as well as giving you a suitable case of
> characters to throw stones, or whatever else is handy, at.
> 
>         Rather interesting that Linus ducked out of town just in time
> for this...  :->
> 

Now we can make this into a conspiracy theory as well =)

> 
>         Mike

-Jeff

-- 
Jeff Golds
Sr. Software Engineer
jgolds@resilience.com

Re: min() and max() in kernel.h ?

[Hua Zhong]

> On Fri, Aug 17, 2001 at 09:13:20PM +0200, Herbert Rosmanith wrote:
> Please review the flamefest threads in this forum going under the
> subjects of "2.4.9 does not compile" and related "[PATCH]".  That will
> answer who what when and why, as well as giving you a suitable case of
> characters to throw stones, or whatever else is handy, at.
>
> Rather interesting that Linus ducked out of town just in time
> for this...  :->

which is the reason why he is smarter than DaveM? :-)

> > /herp
>
> Mike
> --
>  Michael H. Warfield    |  (770) 985-6132   |  mhw@WittsEnd.com
>   (The Mad Wizard)      |  (678) 463-0932   |
http://www.wittsend.com/mhw/
>   NIC whois:  MHW9      |  An optimist believes we live in the best of all
>  PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: min() and max() in kernel.h ?

[Ingo Oeser]

On Fri, Aug 17, 2001 at 09:13:20PM +0200, Herbert Rosmanith wrote:
> I then found min() being defined in <linux/kernel.h> with an additional
> type argument and some superfluos (imo) assignment code. Erm. What's going
> next, drawing elipses in kernel?
 
The assignment is needed to avoid side effects. Only the
type-argument is discussable. But it is needed due to constants
and sign issues. Details are in the archive.

But I didn't add it, I just understand the reasoning of it an
its implementation.

Regards

Ingo Oeser
-- 
In der Wunschphantasie vieler Mann-Typen [ist die Frau] unsigned und
operatorvertraeglich. --- Dietz Proepper in dasr