public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Jeff Chua'" <jeff.chua.linux@gmail.com>
Cc: "'Al Viro'" <viro@zeniv.linux.org.uk>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: can't boot with reiserfs on linux-4.6.0+
Date: Thu, 26 May 2016 15:46:14 +0800	[thread overview]
Message-ID: <017c01d1b722$ae11fac0$0a35f040$@alibaba-inc.com> (raw)
In-Reply-To: <017b01d1b721$d1686aa0$74393fe0$@alibaba-inc.com>

> > See if this fixes your reproducer.
> >
> > diff --git a/fs/xattr.c b/fs/xattr.c
> > index b11945e..49b8eab 100644
> > --- a/fs/xattr.c
> > +++ b/fs/xattr.c
> > @@ -667,6 +667,9 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
> >  {
> >         const struct xattr_handler *handler;
> >
> > +       if (!handlers)
> > +               return NULL;
> > +
> >         if (!*name)
> >                 return NULL;
> >
> 
> Tried, but doesn't work.
> 
See if this fixes your reproducer.

--- linux-4.6/fs/xattr.c	Mon May 16 06:43:13 2016
+++ b/fs/xattr.c	Thu May 26 15:36:14 2016
@@ -667,8 +667,8 @@ xattr_resolve_name(const struct xattr_ha
 {
 	const struct xattr_handler *handler;
 
-	if (!*name)
-		return NULL;
+	if (!handlers || !*name)
+		return ERR_PTR(-EINVAL);
 
 	for_each_xattr_handler(handlers, handler) {
 		const char *n;
--

       reply	other threads:[~2016-05-26  7:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <017b01d1b721$d1686aa0$74393fe0$@alibaba-inc.com>
2016-05-26  7:46 ` Hillf Danton [this message]
2016-05-26 22:49   ` can't boot with reiserfs on linux-4.6.0+ Jeff Chua
2016-05-24 14:10 Jeff Chua
2016-05-24 15:59 ` Al Viro
2016-05-24 16:10   ` Linus Torvalds
2016-05-25  8:38     ` Jeff Chua
2016-05-24 18:37   ` Al Viro
2016-05-25  9:30     ` Jeff Chua
2016-05-25 15:51       ` Linus Torvalds
2016-05-25 15:51       ` Al Viro
2016-05-26  7:20         ` Jeff Chua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='017c01d1b722$ae11fac0$0a35f040$@alibaba-inc.com' \
    --to=hillf.zj@alibaba-inc.com \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox