From: Paul Moore <paul@paul-moore.com>
To: Jori Koolstra <jkoolstra@xs4all.nl>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Eric Paris <eparis@redhat.com>
Cc: Jan Kara <jack@suse.cz>, NeilBrown <neil@brown.name>,
linux-fsdevel@vger.kernel.org, audit@vger.kernel.org,
linux-kernel@vger.kernel.org, Jori Koolstra <jkoolstra@xs4all.nl>
Subject: Re: [PATCH 1/3] vfs: move create error && negative dentry case in lookup_open() up
Date: Fri, 24 Jul 2026 17:10:34 -0400 [thread overview]
Message-ID: <0194430e27db3bcdffcf95b5dbf4891c@paul-moore.com> (raw)
In-Reply-To: <20260710164233.827744-2-jkoolstra@xs4all.nl>
On Jul 10, 2026 Jori Koolstra <jkoolstra@xs4all.nl> wrote:
>
> O_CREAT is stripped when create_error is set in lookup_open(), so when
> lookup does not return an inode, the case
>
> if (!dentry->d_inode && (open_flag & O_CREAT))
>
> is always skipped. We can get rid of this cognitive step by handling the
> error case first.
>
> Reviewed-by: NeilBrown <neil@brown.name>
> Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl>
> ---
> fs/namei.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Paul Moore <paul@paul-moore.com>
--
paul-moore.com
next prev parent reply other threads:[~2026-07-24 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 16:42 [PATCH 0/3] vfs: call audit_inode_child() in lookup_open() on failure Jori Koolstra
2026-07-10 16:42 ` [PATCH 1/3] vfs: move create error && negative dentry case in lookup_open() up Jori Koolstra
2026-07-24 21:10 ` Paul Moore [this message]
2026-07-10 16:42 ` [PATCH 2/3] vfs: call audit_inode_child() in lookup_open() on failure Jori Koolstra
2026-07-24 21:10 ` Paul Moore
2026-07-10 16:42 ` [PATCH 3/3] fs/namei.c: update kerneldoc of atomic_open() Jori Koolstra
2026-07-24 21:10 ` Paul Moore
2026-07-22 14:40 ` [PATCH 0/3] vfs: call audit_inode_child() in lookup_open() on failure Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0194430e27db3bcdffcf95b5dbf4891c@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=eparis@redhat.com \
--cc=jack@suse.cz \
--cc=jkoolstra@xs4all.nl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox