From: Mukesh Ojha <mojha@codeaurora.org>
To: David Laight <David.Laight@ACULAB.COM>,
'Aditya Pakki' <pakki001@umn.edu>
Cc: "kjlu@umn.edu" <kjlu@umn.edu>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xdp-newbies@vger.kernel.org" <xdp-newbies@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup
Date: Wed, 20 Mar 2019 17:48:55 +0530 [thread overview]
Message-ID: <034573d6-61dc-4555-2559-acb4aa86dabe@codeaurora.org> (raw)
In-Reply-To: <57793438545e41cc85d00beab7505143@AcuMS.aculab.com>
On 3/20/2019 4:27 PM, David Laight wrote:
> From: Aditya Pakki
>> Sent: 18 March 2019 22:55
>>
>> kmemdup can fail and return a NULL pointer. The patch modifies the
>> signature of tb_xdp_schedule_request and passes the failure error upstream.
>>
>> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
>> ---
>> drivers/thunderbolt/xdomain.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
>> index e27dd8beb94b..b0e9cc30d708 100644
>> --- a/drivers/thunderbolt/xdomain.c
>> +++ b/drivers/thunderbolt/xdomain.c
>> @@ -526,7 +526,7 @@ static void tb_xdp_handle_request(struct work_struct *work)
>> kfree(xw);
>> }
>>
>> -static void
>> +static bool
>> tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr,
>> size_t size)
>> {
>> @@ -534,13 +534,16 @@ tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr,
>>
>> xw = kmalloc(sizeof(*xw), GFP_KERNEL);
>> if (!xw)
>> - return;
>> + return false;
>>
>> INIT_WORK(&xw->work, tb_xdp_handle_request);
>> xw->pkg = kmemdup(hdr, size, GFP_KERNEL);
>> + if (!xw->pkg)
>> + return false;
> You're leaking 'xw' here.
Yes , Clean up is missing otherwise patch looks good.
Mukesh
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
prev parent reply other threads:[~2019-03-20 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 22:55 [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup Aditya Pakki
2019-03-20 10:51 ` Mika Westerberg
2019-03-20 10:57 ` David Laight
2019-03-20 12:18 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=034573d6-61dc-4555-2559-acb4aa86dabe@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=David.Laight@ACULAB.COM \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox