From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
xdp-newbies@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup
Date: Wed, 20 Mar 2019 12:51:04 +0200 [thread overview]
Message-ID: <20190320105104.GS3622@lahna.fi.intel.com> (raw)
In-Reply-To: <20190318225508.7886-1-pakki001@umn.edu>
On Mon, Mar 18, 2019 at 05:55:08PM -0500, Aditya Pakki wrote:
> @@ -1417,8 +1420,7 @@ bool tb_xdomain_handle_request(struct tb *tb, enum tb_cfg_pkg_type type,
> */
> if (uuid_equal(&hdr->uuid, &tb_xdp_uuid)) {
> if (type == TB_CFG_PKG_XDOMAIN_REQ) {
> - tb_xdp_schedule_request(tb, hdr, size);
> - return true;
> + return tb_xdp_schedule_request(tb, hdr, size);
Please remove parens as well that there is only a single statement
following the if-block.
Otherwise looks fine.
next prev parent reply other threads:[~2019-03-20 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 22:55 [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup Aditya Pakki
2019-03-20 10:51 ` Mika Westerberg [this message]
2019-03-20 10:57 ` David Laight
2019-03-20 12:18 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320105104.GS3622@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox