From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Aaron Ma <aaron.ma@canonical.com>,
oder_chiou@realtek.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
"shumingf@realtek.com" <shumingf@realtek.com>
Subject: Re: [PATCH] ASoC: rt722-sdca: add FU06 Playback Switch for speaker mute control
Date: Mon, 27 Apr 2026 16:53:20 +0200 [thread overview]
Message-ID: <04b94a00-18ef-4540-ac49-a93d2247a603@linux.dev> (raw)
In-Reply-To: <aeuR4AddzJ2sKU1e@opensource.cirrus.com>
On 4/24/26 17:53, Charles Keepax wrote:
> On Fri, Apr 24, 2026 at 03:09:10PM +0200, Pierre-Louis Bossart wrote:
>> On 4/24/26 05:52, Aaron Ma wrote:
>>> On Thu, Apr 23, 2026 at 9:01 PM Pierre-Louis Bossart
>>> <pierre-louis.bossart@linux.dev> wrote:
>>>> On 4/23/26 12:13, Aaron Ma wrote:
>> While I am at it, in theory those registers are Dual-Ranked,
>> with a 'commit' mechanism to deal with all volume changes
>> at the same time. We'll need to add support for Dual-Ranked
>> registers at some point, not sure how this can be bolted in
>> regmap support... Cc: Charles for future SDCA improvements...
>
> Eek... *hides in dark corner*. Yeah at some point we do need
> to do some thinking about dual ranked controls, at the moment
> there is no support. As far as my thinking got was really it
> is in a lot of situations hard to tell which writes you want
> to group. There is some low hanging fruit, for example stereo
> volumes would make sense to group if dual ranked. Although in
> those cases I tend to see user-space changing the volumes one
> channel at a time anyway. And that is even before you get to the
> regmap implementation details which is foggy at best in my mind.
>
> Sorry I don't have more, it is loosely on my virtual todo list,
> but definitely not something I have got around to thinking
> through yet.
Yeah I can't say I have a good view either...
In theory at the Function level there is a Commit Group mask, a Function can be a member of multiple groups.
The fun part is this statement in the spec
"This Control selects the Commit Group(s) which contain every dual-ranked Control within this Function."
but then the SoundWire spec says
"Every Dual-Ranked Register is associated with one or more of 7 Commit Groups"
interesting wording, I am in the dark on how we would know which controls are part of which Commit Group.
And then IIRC there was a desire to update volume controls on multiple devices, e.g. if there are multiple amps the volumes would be updated across devices.
Not sure how to achieve this...
next prev parent reply other threads:[~2026-04-28 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 10:13 [PATCH] ASoC: rt722-sdca: add FU06 Playback Switch for speaker mute control Aaron Ma
2026-04-23 13:01 ` Pierre-Louis Bossart
2026-04-24 3:52 ` Aaron Ma
2026-04-24 13:09 ` Pierre-Louis Bossart
2026-04-24 15:53 ` Charles Keepax
2026-04-27 14:53 ` Pierre-Louis Bossart [this message]
2026-04-29 9:23 ` Charles Keepax
2026-04-26 23:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b94a00-18ef-4540-ac49-a93d2247a603@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=aaron.ma@canonical.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox