public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: Aaron Ma <aaron.ma@canonical.com>,
	oder_chiou@realtek.com, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"shumingf@realtek.com" <shumingf@realtek.com>
Subject: Re: [PATCH] ASoC: rt722-sdca: add FU06 Playback Switch for speaker mute control
Date: Wed, 29 Apr 2026 10:23:56 +0100	[thread overview]
Message-ID: <afHOLFWeDgwPhzUB@opensource.cirrus.com> (raw)
In-Reply-To: <04b94a00-18ef-4540-ac49-a93d2247a603@linux.dev>

On Mon, Apr 27, 2026 at 04:53:20PM +0200, Pierre-Louis Bossart wrote:
> On 4/24/26 17:53, Charles Keepax wrote:
> > On Fri, Apr 24, 2026 at 03:09:10PM +0200, Pierre-Louis Bossart wrote:
> >> On 4/24/26 05:52, Aaron Ma wrote:
> >>> On Thu, Apr 23, 2026 at 9:01 PM Pierre-Louis Bossart
> >>> <pierre-louis.bossart@linux.dev> wrote:
> >>>> On 4/23/26 12:13, Aaron Ma wrote:
> Yeah I can't say I have a good view either...
> 
> In theory at the Function level there is a Commit Group mask,
> a Function can be a member of multiple groups. The fun part
> is this statement in the spec
> 
> "This Control selects the Commit Group(s) which contain every
> dual-ranked Control within this Function."
> 
> but then the SoundWire spec says
> 
> "Every Dual-Ranked Register is associated with one or more of
> 7 Commit Groups"
> 
> interesting wording, I am in the dark on how we would know
> which controls are part of which Commit Group.

There is "Atomic Behaviors Using Dual-Ranked Controls and Commit"
10.3.8 (in 1.0), 13.4 (1.1), which gives some examples of how one
could group stuff. Although its unclear to me how much these are
"recommendations" and how much they are an exhaustive list.

> And then IIRC there was a desire to update volume controls on
> multiple devices, e.g. if there are multiple amps the volumes
> would be updated across devices. Not sure how to achieve
> this...

phew... yeah I hadn't even remotely considered commit groups
spanning functions or indeed even devices. That is indeed some
scary stuff.

Thanks,
Charles

  reply	other threads:[~2026-04-29  9:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 10:13 [PATCH] ASoC: rt722-sdca: add FU06 Playback Switch for speaker mute control Aaron Ma
2026-04-23 13:01 ` Pierre-Louis Bossart
2026-04-24  3:52   ` Aaron Ma
2026-04-24 13:09     ` Pierre-Louis Bossart
2026-04-24 15:53       ` Charles Keepax
2026-04-27 14:53         ` Pierre-Louis Bossart
2026-04-29  9:23           ` Charles Keepax [this message]
2026-04-26 23:23 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afHOLFWeDgwPhzUB@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=aaron.ma@canonical.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=shumingf@realtek.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox