From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
skhan@linuxfoundation.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: socfpga: Add Altera SOCFPGA SDRAM EDAS
Date: Thu, 1 Aug 2024 10:46:14 +0200 [thread overview]
Message-ID: <0582fd8a-216a-4569-a1ad-e4aafc926bf1@kernel.org> (raw)
In-Reply-To: <5f9f4062-91e0-43e0-9ef5-48e30ca68ac9@kernel.org>
On 01/08/2024 10:44, Krzysztof Kozlowski wrote:
> On 01/08/2024 01:02, Alessandro Zanni wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
>
>> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
>> new file mode 100644
>> index 000000000000..78fbe31e4a2b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
>
> Filename like compatible, so altr,sdram-edac.yaml
>
> Fix the placement - arm is only for top-level sutff. This goes to
> memory-controllers or edac
>
So this was a v2? Then version your patches correctly and add
appropriate and detailed changelog under ---.
See submitting patches.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-01 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 23:02 [PATCH] dt-bindings: arm: socfpga: Add Altera SOCFPGA SDRAM EDAS Alessandro Zanni
2024-08-01 8:44 ` Krzysztof Kozlowski
2024-08-01 8:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0582fd8a-216a-4569-a1ad-e4aafc926bf1@kernel.org \
--to=krzk@kernel.org \
--cc=alessandro.zanni87@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox