From: Paul Walmsley <pjw@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Björn Töpel" <bjorn@rivosinc.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Yu-Chun Lin" <eleanor.lin@realtek.com>,
"Kuan-Wei Chiu" <visitorckw@gmail.com>,
"Han Gao" <rabenda.cn@gmail.com>,
"Nam Cao" <namcao@linutronix.de>, "Pu Lehui" <pulehui@huawei.com>,
"Klara Modin" <klarasmodin@gmail.com>,
"Ben Dooks" <ben.dooks@codethink.co.uk>,
"Alexandre Ghiti" <alexghiti@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] riscv: propagate insert_resource result from add_resource
Date: Wed, 13 May 2026 16:58:55 -0600 (MDT) [thread overview]
Message-ID: <05988bfc-6de7-1011-6535-a80c7a710282@kernel.org> (raw)
In-Reply-To: <20260512172034.328405-4-thorsten.blum@linux.dev>
On Tue, 12 May 2026, Thorsten Blum wrote:
> Currently, add_resource() returns 1 on success, even though its callers
> only check for negative values. Instead, propagate the insert_resource()
> result from add_resource() to align with standard kernel return-value
> conventions (0 on success, negative errno on failure).
>
> Use %pR to print the full resource range while at it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Thanks, queued for v7.2.
- Paul
prev parent reply other threads:[~2026-05-13 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 17:20 [PATCH v2] riscv: propagate insert_resource result from add_resource Thorsten Blum
2026-05-13 22:58 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05988bfc-6de7-1011-6535-a80c7a710282@kernel.org \
--to=pjw@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=ben.dooks@codethink.co.uk \
--cc=bjorn@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=eleanor.lin@realtek.com \
--cc=klarasmodin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=namcao@linutronix.de \
--cc=palmer@dabbelt.com \
--cc=pulehui@huawei.com \
--cc=rabenda.cn@gmail.com \
--cc=thorsten.blum@linux.dev \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox