From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Documentation" <linux-doc@vger.kernel.org>,
"Linux DRI Development" <dri-devel@lists.freedesktop.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Javier Garcia" <rampxxxx@gmail.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Antonino Maniscalco" <antomani103@gmail.com>,
"Rob Clark" <robin.clark@oss.qualcomm.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: [PATCH] Revert "drm: Add directive to format code in comment"
Date: Sat, 13 Sep 2025 05:25:06 +0700 [thread overview]
Message-ID: <0680f2fa-e583-4b7d-a1ff-9fcd4c5a8269@gmail.com> (raw)
In-Reply-To: <e0252635-4dc4-483a-911a-fee5a36c19c3@kernel.org>
On 9/13/25 04:27, Danilo Krummrich wrote:
> On 9/12/25 3:06 PM, Bagas Sanjaya wrote:
>> Commit 6cc44e9618f03f ("drm: Add directive to format code in comment")
>> fixes original Sphinx indentation warning as introduced in
>> 471920ce25d50b ("drm/gpuvm: Add locking helpers"), by means of using
>> code-block:: directive. It semantically conflicts with earlier
>> bb324f85f72284 ("drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected
>> usage in literal code block") that did the same using double colon
>> syntax instead. These duplicated literal code block directives causes
>> the original warnings not being fixed.
>>
>> Revert 6cc44e9618f03f to keep things rolling without these warnings.
>>
>> Fixes: 6cc44e9618f0 ("drm: Add directive to format code in comment")
>> Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")
>> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
> Need me to pick this one up? Otherwise,
>
Of course!
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2025-09-12 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 13:06 [PATCH] Revert "drm: Add directive to format code in comment" Bagas Sanjaya
2025-09-12 20:58 ` Randy Dunlap
2025-09-12 21:27 ` Danilo Krummrich
2025-09-12 22:25 ` Bagas Sanjaya [this message]
2025-09-13 9:20 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0680f2fa-e583-4b7d-a1ff-9fcd4c5a8269@gmail.com \
--to=bagasdotme@gmail.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=antomani103@gmail.com \
--cc=dakr@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=rampxxxx@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sfr@canb.auug.org.au \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox