* [PATCH] Revert "drm: Add directive to format code in comment"
@ 2025-09-12 13:06 Bagas Sanjaya
2025-09-12 20:58 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bagas Sanjaya @ 2025-09-12 13:06 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation,
Linux DRI Development
Cc: Danilo Krummrich, Matthew Brost, Thomas Hellström,
Alice Ryhl, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Javier Garcia, Dmitry Baryshkov,
Bagas Sanjaya, Antonino Maniscalco, Rob Clark, Randy Dunlap,
Stephen Rothwell
Commit 6cc44e9618f03f ("drm: Add directive to format code in comment")
fixes original Sphinx indentation warning as introduced in
471920ce25d50b ("drm/gpuvm: Add locking helpers"), by means of using
code-block:: directive. It semantically conflicts with earlier
bb324f85f72284 ("drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected
usage in literal code block") that did the same using double colon
syntax instead. These duplicated literal code block directives causes
the original warnings not being fixed.
Revert 6cc44e9618f03f to keep things rolling without these warnings.
Fixes: 6cc44e9618f0 ("drm: Add directive to format code in comment")
Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
drivers/gpu/drm/drm_gpuvm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index db9b089ef62c85..86853535fb7bd7 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -2432,8 +2432,6 @@ static const struct drm_gpuvm_ops lock_ops = {
*
* The expected usage is::
*
- * .. code-block:: c
- *
* vm_bind {
* struct drm_exec exec;
*
base-commit: 9a3f210737e958c3f45a4ce0d7f1ff330af3965f
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm: Add directive to format code in comment"
2025-09-12 13:06 [PATCH] Revert "drm: Add directive to format code in comment" Bagas Sanjaya
@ 2025-09-12 20:58 ` Randy Dunlap
2025-09-12 21:27 ` Danilo Krummrich
2025-09-13 9:20 ` Danilo Krummrich
2 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2025-09-12 20:58 UTC (permalink / raw)
To: Bagas Sanjaya, Linux Kernel Mailing List, Linux Documentation,
Linux DRI Development
Cc: Danilo Krummrich, Matthew Brost, Thomas Hellström,
Alice Ryhl, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Javier Garcia, Dmitry Baryshkov,
Antonino Maniscalco, Rob Clark, Stephen Rothwell
On 9/12/25 6:06 AM, Bagas Sanjaya wrote:
> Commit 6cc44e9618f03f ("drm: Add directive to format code in comment")
> fixes original Sphinx indentation warning as introduced in
> 471920ce25d50b ("drm/gpuvm: Add locking helpers"), by means of using
> code-block:: directive. It semantically conflicts with earlier
> bb324f85f72284 ("drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected
> usage in literal code block") that did the same using double colon
> syntax instead. These duplicated literal code block directives causes
> the original warnings not being fixed.
>
> Revert 6cc44e9618f03f to keep things rolling without these warnings.
>
> Fixes: 6cc44e9618f0 ("drm: Add directive to format code in comment")
> Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks!
> ---
> drivers/gpu/drm/drm_gpuvm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> index db9b089ef62c85..86853535fb7bd7 100644
> --- a/drivers/gpu/drm/drm_gpuvm.c
> +++ b/drivers/gpu/drm/drm_gpuvm.c
> @@ -2432,8 +2432,6 @@ static const struct drm_gpuvm_ops lock_ops = {
> *
> * The expected usage is::
> *
> - * .. code-block:: c
> - *
> * vm_bind {
> * struct drm_exec exec;
> *
>
> base-commit: 9a3f210737e958c3f45a4ce0d7f1ff330af3965f
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm: Add directive to format code in comment"
2025-09-12 13:06 [PATCH] Revert "drm: Add directive to format code in comment" Bagas Sanjaya
2025-09-12 20:58 ` Randy Dunlap
@ 2025-09-12 21:27 ` Danilo Krummrich
2025-09-12 22:25 ` Bagas Sanjaya
2025-09-13 9:20 ` Danilo Krummrich
2 siblings, 1 reply; 5+ messages in thread
From: Danilo Krummrich @ 2025-09-12 21:27 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Linux Kernel Mailing List, Linux Documentation,
Linux DRI Development, Matthew Brost, Thomas Hellström,
Alice Ryhl, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Javier Garcia, Dmitry Baryshkov,
Antonino Maniscalco, Rob Clark, Randy Dunlap, Stephen Rothwell
On 9/12/25 3:06 PM, Bagas Sanjaya wrote:
> Commit 6cc44e9618f03f ("drm: Add directive to format code in comment")
> fixes original Sphinx indentation warning as introduced in
> 471920ce25d50b ("drm/gpuvm: Add locking helpers"), by means of using
> code-block:: directive. It semantically conflicts with earlier
> bb324f85f72284 ("drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected
> usage in literal code block") that did the same using double colon
> syntax instead. These duplicated literal code block directives causes
> the original warnings not being fixed.
>
> Revert 6cc44e9618f03f to keep things rolling without these warnings.
>
> Fixes: 6cc44e9618f0 ("drm: Add directive to format code in comment")
> Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Need me to pick this one up? Otherwise,
Acked-by: Danilo Krummrich <dakr@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm: Add directive to format code in comment"
2025-09-12 21:27 ` Danilo Krummrich
@ 2025-09-12 22:25 ` Bagas Sanjaya
0 siblings, 0 replies; 5+ messages in thread
From: Bagas Sanjaya @ 2025-09-12 22:25 UTC (permalink / raw)
To: Danilo Krummrich
Cc: Linux Kernel Mailing List, Linux Documentation,
Linux DRI Development, Matthew Brost, Thomas Hellström,
Alice Ryhl, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Javier Garcia, Dmitry Baryshkov,
Antonino Maniscalco, Rob Clark, Randy Dunlap, Stephen Rothwell
On 9/13/25 04:27, Danilo Krummrich wrote:
> On 9/12/25 3:06 PM, Bagas Sanjaya wrote:
>> Commit 6cc44e9618f03f ("drm: Add directive to format code in comment")
>> fixes original Sphinx indentation warning as introduced in
>> 471920ce25d50b ("drm/gpuvm: Add locking helpers"), by means of using
>> code-block:: directive. It semantically conflicts with earlier
>> bb324f85f72284 ("drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected
>> usage in literal code block") that did the same using double colon
>> syntax instead. These duplicated literal code block directives causes
>> the original warnings not being fixed.
>>
>> Revert 6cc44e9618f03f to keep things rolling without these warnings.
>>
>> Fixes: 6cc44e9618f0 ("drm: Add directive to format code in comment")
>> Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")
>> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
> Need me to pick this one up? Otherwise,
>
Of course!
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "drm: Add directive to format code in comment"
2025-09-12 13:06 [PATCH] Revert "drm: Add directive to format code in comment" Bagas Sanjaya
2025-09-12 20:58 ` Randy Dunlap
2025-09-12 21:27 ` Danilo Krummrich
@ 2025-09-13 9:20 ` Danilo Krummrich
2 siblings, 0 replies; 5+ messages in thread
From: Danilo Krummrich @ 2025-09-13 9:20 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Linux Kernel Mailing List, Linux Documentation,
Linux DRI Development, Matthew Brost, Thomas Hellström,
Alice Ryhl, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Javier Garcia, Dmitry Baryshkov,
Antonino Maniscalco, Rob Clark, Randy Dunlap, Stephen Rothwell
On 9/12/25 3:06 PM, Bagas Sanjaya wrote:
> Commit 6cc44e9618f03f ("drm: Add directive to format code in comment")
> fixes original Sphinx indentation warning as introduced in
> 471920ce25d50b ("drm/gpuvm: Add locking helpers"), by means of using
> code-block:: directive. It semantically conflicts with earlier
> bb324f85f72284 ("drm/gpuvm: Wrap drm_gpuvm_sm_map_exec_lock() expected
> usage in literal code block") that did the same using double colon
> syntax instead. These duplicated literal code block directives causes
> the original warnings not being fixed.
>
> Revert 6cc44e9618f03f to keep things rolling without these warnings.
>
> Fixes: 6cc44e9618f0 ("drm: Add directive to format code in comment")
> Fixes: 471920ce25d5 ("drm/gpuvm: Add locking helpers")
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Applied to drm-misc-fixes, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-09-13 9:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-12 13:06 [PATCH] Revert "drm: Add directive to format code in comment" Bagas Sanjaya
2025-09-12 20:58 ` Randy Dunlap
2025-09-12 21:27 ` Danilo Krummrich
2025-09-12 22:25 ` Bagas Sanjaya
2025-09-13 9:20 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox