From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
brgl@kernel.org, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/surface: gpe: add missing err.h include
Date: Mon, 27 Jul 2026 21:46:49 +0300 (EEST) [thread overview]
Message-ID: <07f6bc90-bb30-9b28-3bb7-eda9c83b3ce8@linux.intel.com> (raw)
In-Reply-To: <20260727144308.61842-1-bartosz.golaszewski@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
On Mon, 27 Jul 2026, Bartosz Golaszewski wrote:
> We now use PTR_ERR() and IS_ERR() in this module so pull in the header
> that provides them.
>
> Fixes: 1e0bd438b876 ("platform/surface: gpe: use platform_device_register_full()")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> This must go through the driver core tree as a follow up to the commit
> it fixes.
>
> drivers/platform/surface/surface_gpe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
> index 4ca7ad76f3b9d..29b264f2a444e 100644
> --- a/drivers/platform/surface/surface_gpe.c
> +++ b/drivers/platform/surface/surface_gpe.c
> @@ -11,6 +11,7 @@
>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
> +#include <linux/err.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2026-07-27 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 14:43 [PATCH] platform/surface: gpe: add missing err.h include Bartosz Golaszewski
2026-07-27 18:46 ` Ilpo Järvinen [this message]
2026-07-27 20:38 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f6bc90-bb30-9b28-3bb7-eda9c83b3ce8@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox