[PATCH] platform/surface: gpe: add missing err.h include

[PATCH] platform/surface: gpe: add missing err.h include

[Bartosz Golaszewski]

We now use PTR_ERR() and IS_ERR() in this module so pull in the header
that provides them.

Fixes: 1e0bd438b876 ("platform/surface: gpe: use platform_device_register_full()")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
This must go through the driver core tree as a follow up to the commit
it fixes.

 drivers/platform/surface/surface_gpe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
index 4ca7ad76f3b9d..29b264f2a444e 100644
--- a/drivers/platform/surface/surface_gpe.c
+++ b/drivers/platform/surface/surface_gpe.c
@@ -11,6 +11,7 @@
 
 #include <linux/acpi.h>
 #include <linux/dmi.h>
+#include <linux/err.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-- 
2.47.3

Re: [PATCH] platform/surface: gpe: add missing err.h include

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On Mon, 27 Jul 2026, Bartosz Golaszewski wrote:

> We now use PTR_ERR() and IS_ERR() in this module so pull in the header
> that provides them.
> 
> Fixes: 1e0bd438b876 ("platform/surface: gpe: use platform_device_register_full()")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> This must go through the driver core tree as a follow up to the commit
> it fixes.
> 
>  drivers/platform/surface/surface_gpe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
> index 4ca7ad76f3b9d..29b264f2a444e 100644
> --- a/drivers/platform/surface/surface_gpe.c
> +++ b/drivers/platform/surface/surface_gpe.c
> @@ -11,6 +11,7 @@
>  
>  #include <linux/acpi.h>
>  #include <linux/dmi.h>
> +#include <linux/err.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

Re: [PATCH] platform/surface: gpe: add missing err.h include

[Danilo Krummrich]

On Mon, 27 Jul 2026 16:43:08 +0200, Bartosz Golaszewski wrote:
> [PATCH] platform/surface: gpe: add missing err.h include

Applied, thanks!

  Branch: driver-core-testing
  Tree:   git://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git

[1/1] platform/surface: gpe: add missing err.h include
      commit: b47dcd7b41e2

The patch will appear in the next linux-next integration (typically within 24
hours on weekdays).

The patch is in the driver-core-testing branch and will be promoted to
driver-core-next after validation.