Re: [PATCH v3] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC

Re: [PATCH v3] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC

[Paul Moore]

On Wed, Apr 8, 2026 at 12:28 AM Madhavan Srinivasan <maddy@linux.ibm.com> wrote:
>
> On Tue, 10 Mar 2026 16:08:07 +0100, Christophe Leroy (CS GROUP) wrote:
> > Commit e65e1fc2d24b ("[PATCH] syscall class hookup for all normal
> > targets") added generic support for AUDIT but that didn't include
> > support for bi-arch like powerpc.
> >
> > Commit 4b58841149dc ("audit: Add generic compat syscall support")
> > added generic support for bi-arch.
> >
> > [...]
>
> Applied to powerpc/next.
>
> [1/1] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC
>       https://git.kernel.org/powerpc/c/f26ad12356a275ab303d5d3af4790ad94acc20d7

I never saw a follow-up demonstrating that the audit test suite runs
clean with this change.

Madhavan, did you test this before merging?

-- 
paul-moore.com

Re: [PATCH v3] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC

[Harsh Prateek Bora]

+ Ritesh

Hi Venkat,

On 11/03/26 12:49 am, Paul Moore wrote:
> On Tue, Mar 10, 2026 at 11:08 AM Christophe Leroy (CS GROUP)
> <chleroy@kernel.org> wrote:
>>
>> From: Christophe Leroy <christophe.leroy@csgroup.eu>
>>
>> Commit e65e1fc2d24b ("[PATCH] syscall class hookup for all normal
>> targets") added generic support for AUDIT but that didn't include
>> support for bi-arch like powerpc.
>>
>> Commit 4b58841149dc ("audit: Add generic compat syscall support")
>> added generic support for bi-arch.
>>
>> Convert powerpc to that bi-arch generic audit support.
>>
>> With this change generated text is similar.
>>
>> Thomas has confirmed that the previously failing filter_exclude/test
>> is now successful both without and with this patch, see [1]
>>
>> [1] https://lore.kernel.org/all/20260306115350-ef265661-6d6b-4043-9bd0-8e6b437d0d67@linutronix.de/
>>
>> Link: https://github.com/linuxppc/issues/issues/412
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>> ---
>> Venkat, a test result with https://github.com/linux-audit/audit-testsuite would be appreciated.
> 
> Yes, I'd like to see confirmation that the audit test suite runs clean
> on ppc systems with this patch applied, and unfortunately without a
> ppc system I have no way to test this myself.

Is it possible to include this test suite in the IBM CI ?

Thanks
Harsh
> 
>> v3: Rebased on v7.0-rc1
>>
>> v2: https://lore.kernel.org/all/a4b3951d1191d4183d92a07a6097566bde60d00a.1629812058.git.christophe.leroy@csgroup.eu/
>> ---
>>   arch/powerpc/Kconfig                |  5 +-
>>   arch/powerpc/include/asm/unistd32.h |  7 +++
>>   arch/powerpc/kernel/Makefile        |  3 -
>>   arch/powerpc/kernel/audit.c         | 87 -----------------------------
>>   arch/powerpc/kernel/compat_audit.c  | 49 ----------------
>>   5 files changed, 8 insertions(+), 143 deletions(-)
>>   create mode 100644 arch/powerpc/include/asm/unistd32.h
>>   delete mode 100644 arch/powerpc/kernel/audit.c
>>   delete mode 100644 arch/powerpc/kernel/compat_audit.c
> 

Re: [PATCH v3] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC

[Madhavan Srinivasan]

On 5/13/26 10:05 AM, Harsh Prateek Bora wrote:
> + Ritesh
>
> Hi Venkat,
>
> On 11/03/26 12:49 am, Paul Moore wrote:
>> On Tue, Mar 10, 2026 at 11:08 AM Christophe Leroy (CS GROUP)
>> <chleroy@kernel.org> wrote:
>>>
>>> From: Christophe Leroy <christophe.leroy@csgroup.eu>
>>>
>>> Commit e65e1fc2d24b ("[PATCH] syscall class hookup for all normal
>>> targets") added generic support for AUDIT but that didn't include
>>> support for bi-arch like powerpc.
>>>
>>> Commit 4b58841149dc ("audit: Add generic compat syscall support")
>>> added generic support for bi-arch.
>>>
>>> Convert powerpc to that bi-arch generic audit support.
>>>
>>> With this change generated text is similar.
>>>
>>> Thomas has confirmed that the previously failing filter_exclude/test
>>> is now successful both without and with this patch, see [1]
>>>
>>> [1] 
>>> https://lore.kernel.org/all/20260306115350-ef265661-6d6b-4043-9bd0-8e6b437d0d67@linutronix.de/
>>>
>>> Link: https://github.com/linuxppc/issues/issues/412
>>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>>> ---
>>> Venkat, a test result with 
>>> https://github.com/linux-audit/audit-testsuite would be appreciated.
>>
>> Yes, I'd like to see confirmation that the audit test suite runs clean
>> on ppc systems with this patch applied, and unfortunately without a
>> ppc system I have no way to test this myself.
>
My bad, this is a miss from my end.
Venkat is already on this and will update the results here.

Maddy


> Is it possible to include this test suite in the IBM CI ?
>
> Thanks
> Harsh
>>
>>> v3: Rebased on v7.0-rc1
>>>
>>> v2: 
>>> https://lore.kernel.org/all/a4b3951d1191d4183d92a07a6097566bde60d00a.1629812058.git.christophe.leroy@csgroup.eu/
>>> ---
>>>   arch/powerpc/Kconfig                |  5 +-
>>>   arch/powerpc/include/asm/unistd32.h |  7 +++
>>>   arch/powerpc/kernel/Makefile        |  3 -
>>>   arch/powerpc/kernel/audit.c         | 87 
>>> -----------------------------
>>>   arch/powerpc/kernel/compat_audit.c  | 49 ----------------
>>>   5 files changed, 8 insertions(+), 143 deletions(-)
>>>   create mode 100644 arch/powerpc/include/asm/unistd32.h
>>>   delete mode 100644 arch/powerpc/kernel/audit.c
>>>   delete mode 100644 arch/powerpc/kernel/compat_audit.c
>>
>
>