From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Stephan Gerhold <stephan.gerhold@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jack Pham <jack.pham@oss.qualcomm.com>,
Abel Vesa <abel.vesa@oss.qualcomm.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ps883x: Fix DP+USB3 configuration
Date: Mon, 8 Jun 2026 10:23:34 +0200 [thread overview]
Message-ID: <0a14d85b-ce64-4c9f-8cc4-23cd0f963d98@oss.qualcomm.com> (raw)
In-Reply-To: <20260601-ps883x-usb3dp-fixes-v1-1-d19bec3a6d26@linaro.org>
On 6/1/26 3:55 PM, Stephan Gerhold wrote:
> Commit 6bebd9b77726 ("usb: typec: ps883x: Rework ps883x_set()") introduced
> two regressions:
>
> 1. The CONN_STATUS_0_USB_3_1_CONNECTED bit is mistakenly written to the
> wrong configuration register (cfg1 instead of cfg0). This breaks USB3
> when using USB3+DP adapters.
>
> 2. The switch-case fallthrough block is inverted: Currently,
> TYPEC_DP_STATE_C (DP-only) inherits the USB3 configuration, while
> TYPEC_DP_STATE_D (DP+USB3) is missing the necessary DP sink flags.
>
> Fix these by writing the USB3 bit to the correct register and swapping the
> case statement order so both states get their correct bits assigned.
Oops.. sorry about this.. I only had a 4lndp display to test the DP
altmode path..
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-06-08 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 13:55 [PATCH] usb: typec: ps883x: Fix DP+USB3 configuration Stephan Gerhold
2026-06-01 18:48 ` Jens Glathe
2026-06-05 12:53 ` Heikki Krogerus
2026-06-08 8:23 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a14d85b-ce64-4c9f-8cc4-23cd0f963d98@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jack.pham@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox