public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	Li peiyu <579lpy@gmail.com>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: fix temperature offset
Date: Thu, 25 Jan 2024 11:49:25 +0100	[thread overview]
Message-ID: <0a98e54735cc2a97f393eef6b1cdaf27c946d10e.camel@gmail.com> (raw)
In-Reply-To: <20240125102641.3850938-1-dima.fedrau@gmail.com>

Hi Dimitri,

On Thu, 2024-01-25 at 11:26 +0100, Dimitri Fedrau wrote:
> The temperature offset should be negative according to the datasheet.
> Adding a minus to the existing offset results in correct temperature
> calculations.
> 
> Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> ---

This is a fix. You're missing a Fixes: tag in your commit message.
git log --grep="Fixes:" should give you some examples...

With that, feel free to add:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

>  drivers/iio/humidity/hdc3020.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
> index 4e3311170725..ed70415512f6 100644
> --- a/drivers/iio/humidity/hdc3020.c
> +++ b/drivers/iio/humidity/hdc3020.c
> @@ -322,7 +322,7 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev,
>  		if (chan->type != IIO_TEMP)
>  			return -EINVAL;
>  
> -		*val = 16852;
> +		*val = -16852;
>  		return IIO_VAL_INT;
>  
>  	default:


  reply	other threads:[~2024-01-25 10:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 10:26 [PATCH] iio: humidity: hdc3020: fix temperature offset Dimitri Fedrau
2024-01-25 10:49 ` Nuno Sá [this message]
2024-01-25 11:08   ` Dimitri Fedrau
2024-01-27 14:37     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a98e54735cc2a97f393eef6b1cdaf27c946d10e.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=579lpy@gmail.com \
    --cc=dima.fedrau@gmail.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox