[PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[Khalid Faisal Ansari]

Enable ST33HTPM TPM over SPI11 on the Hamoa IoT EVK by adding the
required SPI and TPM nodes.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
---
Testing:
- TPM detected via tpm_tis_spi
- Verified functionality using tpm2-tools (e.g. tpm2_getrandom, tpm2_rsadecrypt)

Depends on:
- <20251106102448.3585332-1-xueyao.an@oss.qualcomm.com>
  Link: https://lore.kernel.org/linux-arm-msm/20251106102448.3585332-1-xueyao.an@oss.qualcomm.com/
---
Changes in v3:
- Squashed patches touching the same file into one.
- Link to v2: https://lore.kernel.org/r/20251111-arm64-dts-qcom-hamoa-iot-evk-enable-st33-tpm-on-spi11-v2-0-101a801974b6@oss.qualcomm.com

Changes in v2:
- Use "tcg,tpm_tis-spi" compatible to satisfy dtbs_check (was vendor-only).
- Add dependency change in cover letter.
- Link to v1: https://lore.kernel.org/r/20251107-arm64-dts-qcom-hamoa-iot-evk-enable-st33-tpm-on-spi11-v1-1-8ba83b58fca7@oss.qualcomm.com
---
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
index 36dd6599402b..aecaebebcef5 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
@@ -917,6 +917,16 @@ &smb2360_2_eusb2_repeater {
 	vdd3-supply = <&vreg_l8b_3p0>;
 };
 
+&spi11 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};
+
 &swr0 {
 	status = "okay";
 

---
base-commit: 9c0826a5d9aa4d52206dd89976858457a2a8a7ed
change-id: 20251107-arm64-dts-qcom-hamoa-iot-evk-enable-st33-tpm-on-spi11-c8353d7fe82e

Best regards,
-- 
Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>

Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[Konrad Dybcio]

On 11/12/25 8:42 AM, Khalid Faisal Ansari wrote:
> Enable ST33HTPM TPM over SPI11 on the Hamoa IoT EVK by adding the
> required SPI and TPM nodes.
> 
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> ---
> Testing:
> - TPM detected via tpm_tis_spi
> - Verified functionality using tpm2-tools (e.g. tpm2_getrandom, tpm2_rsadecrypt)
> 
> Depends on:
> - <20251106102448.3585332-1-xueyao.an@oss.qualcomm.com>
>   Link: https://lore.kernel.org/linux-arm-msm/20251106102448.3585332-1-xueyao.an@oss.qualcomm.com/
> ---
> Changes in v3:
> - Squashed patches touching the same file into one.

Doesn't seem to be the case

Konrad

> - Link to v2: https://lore.kernel.org/r/20251111-arm64-dts-qcom-hamoa-iot-evk-enable-st33-tpm-on-spi11-v2-0-101a801974b6@oss.qualcomm.com
> 
> Changes in v2:
> - Use "tcg,tpm_tis-spi" compatible to satisfy dtbs_check (was vendor-only).
> - Add dependency change in cover letter.
> - Link to v1: https://lore.kernel.org/r/20251107-arm64-dts-qcom-hamoa-iot-evk-enable-st33-tpm-on-spi11-v1-1-8ba83b58fca7@oss.qualcomm.com
> ---
>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 36dd6599402b..aecaebebcef5 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> @@ -917,6 +917,16 @@ &smb2360_2_eusb2_repeater {
>  	vdd3-supply = <&vreg_l8b_3p0>;
>  };
>  
> +&spi11 {
> +	status = "okay";
> +
> +	tpm@0 {
> +		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
> +		reg = <0>;
> +		spi-max-frequency = <20000000>;
> +	};
> +};
> +
>  &swr0 {
>  	status = "okay";
>  
> 
> ---
> base-commit: 9c0826a5d9aa4d52206dd89976858457a2a8a7ed
> change-id: 20251107-arm64-dts-qcom-hamoa-iot-evk-enable-st33-tpm-on-spi11-c8353d7fe82e
> 
> Best regards,

Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[Konrad Dybcio]

On 11/12/25 10:28 AM, Konrad Dybcio wrote:
> On 11/12/25 8:42 AM, Khalid Faisal Ansari wrote:
>> Enable ST33HTPM TPM over SPI11 on the Hamoa IoT EVK by adding the
>> required SPI and TPM nodes.
>>
>> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>> ---
>> Testing:
>> - TPM detected via tpm_tis_spi
>> - Verified functionality using tpm2-tools (e.g. tpm2_getrandom, tpm2_rsadecrypt)
>>
>> Depends on:
>> - <20251106102448.3585332-1-xueyao.an@oss.qualcomm.com>
>>   Link: https://lore.kernel.org/linux-arm-msm/20251106102448.3585332-1-xueyao.an@oss.qualcomm.com/
>> ---
>> Changes in v3:
>> - Squashed patches touching the same file into one.
> 
> Doesn't seem to be the case

The author was referring to a faulty previous revision, not my
suggestion of coupling this with the dependency

for this change:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[Khalid Faisal Ansari]

Hi Kernel Reviewers,

I wanted to follow up regarding the patch. It was reviewed but hasn’t 
been applied yet. Please let me know if there’s anything pending on my 
side or any additional changes required.

Thanks

On 11/12/25 16:39, Konrad Dybcio wrote:
> On 11/12/25 10:28 AM, Konrad Dybcio wrote:
>> On 11/12/25 8:42 AM, Khalid Faisal Ansari wrote:
>>> Enable ST33HTPM TPM over SPI11 on the Hamoa IoT EVK by adding the
>>> required SPI and TPM nodes.
>>>
>>> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>>> ---
>>> Testing:
>>> - TPM detected via tpm_tis_spi
>>> - Verified functionality using tpm2-tools (e.g. tpm2_getrandom, tpm2_rsadecrypt)
>>>
>>> Depends on:
>>> - <20251106102448.3585332-1-xueyao.an@oss.qualcomm.com>
>>>    Link: https://lore.kernel.org/linux-arm-msm/20251106102448.3585332-1-xueyao.an@oss.qualcomm.com/
>>> ---
>>> Changes in v3:
>>> - Squashed patches touching the same file into one.
>>
>> Doesn't seem to be the case
> 
> The author was referring to a faulty previous revision, not my
> suggestion of coupling this with the dependency
> 
> for this change:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Konrad

Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[Khalid Faisal Ansari]

On 11/12/2025 4:39 PM, Konrad Dybcio wrote:
> On 11/12/25 10:28 AM, Konrad Dybcio wrote:
>> On 11/12/25 8:42 AM, Khalid Faisal Ansari wrote:
>>> Enable ST33HTPM TPM over SPI11 on the Hamoa IoT EVK by adding the
>>> required SPI and TPM nodes.
>>>
>>> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>>> ---
>>> Testing:
>>> - TPM detected via tpm_tis_spi
>>> - Verified functionality using tpm2-tools (e.g. tpm2_getrandom, tpm2_rsadecrypt)
>>>
>>> Depends on:
>>> - <20251106102448.3585332-1-xueyao.an@oss.qualcomm.com>
>>>    Link: https://lore.kernel.org/linux-arm-msm/20251106102448.3585332-1-xueyao.an@oss.qualcomm.com/
>>> ---
>>> Changes in v3:
>>> - Squashed patches touching the same file into one.
>> Doesn't seem to be the case
> The author was referring to a faulty previous revision, not my
> suggestion of coupling this with the dependency
>
> for this change:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad

Hi Kernel Reviewers,

just wanted to follow up regarding current patch. It was reviewed but 
hasn’t been applied yet. Please let me know if there’s anything pending 
on my side or any additional changes required.

Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11

[Bjorn Andersson]

On Wed, 12 Nov 2025 13:12:09 +0530, Khalid Faisal Ansari wrote:
> Enable ST33HTPM TPM over SPI11 on the Hamoa IoT EVK by adding the
> required SPI and TPM nodes.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: hamoa-iot-evk: Enable TPM (ST33) on SPI11
      commit: 54b5415739300c89cdd6b1db152bb5acf047ce40

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>