Re: [PATCH 2/4] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node

[Andrew Davis <afd@ti.com>]

On 1/30/25 4:40 PM, Judith Mendez wrote:
> On 1/28/25 11:48 AM, Judith Mendez wrote:
>> Hi Andrew,
>>
>> On 1/28/25 10:52 AM, Hari Nagalla wrote:
>>> On 1/28/25 10:27, Andrew Davis wrote:
>>>>> +    mcu_r5fss0: r5fss@79000000 {
>>>>> +        compatible = "ti,am62-r5fss";
>>>>> +        #address-cells = <1>;
>>>>> +        #size-cells = <1>;
>>>>> +        ranges = <0x79000000 0x00 0x79000000 0x8000>,
>>>>> +             <0x79020000 0x00 0x79020000 0x8000>;
>>>>> +        power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
>>>>
>>>> Newline here.
>>>>
>>>> Also this should be default "disabled". It can be set to "okay"
>>>> in the board DTS file when the needed mboxes and memory-region
>>>> are set. Speaking of that, where are those patches? This is
>>>> incomplete without them and these nodes will not function.
>>>> Same for the DSP patch.
>>>>
>>>> Andrew
>>> Yes, by default needs to set the node state to "disabled". This is HW description of the wake-up domain components. Memory carve outs and mailbox assignments for IPC are a separate patch as it is configurable and distro dependent.
>>
>> Yes I plan to disable the nodes in each domain .dtsi file.
>>
>> Also yes, my understanding is that the memory carveouts could
>> be a separate series if at all. Not sure if those patches can be
>> sent upstream since they are distro dependent. Can anyone clarify
>> if this is the case?
>>
> 
> As per offline discussion, I will include the memory carveouts in this
> same series.

It's usually good to fill in some details of "offline discussion" for
folks on the list not in that conversation.

By "distro dependent" we really mean firmware dependent. The carveouts
are set in DT and then most firmware follows the same and hardcode
these addresses. For example[0].

This works well as long as all the firmware uses these standard
addresses. Problem is some legacy firmware did not, and so to use
those firmware the DT would need modified.

For AM62 and AM62A I'm not aware of any such firmware. So this
is a bit of a non-issue and we can safely add the carveouts
like we already do for all other K3 devices.

Andrew

[0] https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/beagle/beaglebone_ai64/beaglebone_ai64_j721e_main_r5f0_0.dts#L30

> ~ Judith
> 
>> ~ Judith
>>
>