[RFC PATCH 00/13] Intel(R) MEI Driver

[RFC PATCH 00/13] Intel(R) MEI Driver

[Oren Weil]

Intel(R) Management Engine Interface (Intel(R) MEI) Driver 
==========================================================

This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

The Intel(R) MEI driver allows applications to access
the Intel(R) Management Engine (Intel(R) ME) FW via the host
interface.


The Intel(R) MEI driver is meant to be used mainly by the
Local Manageability Service (LMS).

Note: This driver was previously called the HECI driver that was
a part of the Staging area in the Kernel and was removed.

The old MEI Driver and LMS are located on openamt.org, and are not updated
with the latest versions. A new version of LMS is under development and will be released
soon.

This set of patches is for review purposes; the driver code
for pull is in the David Woodhouse public git repository:
http://git.infradead.org/linux-2.6-mei.git

The patches is divided according to the driver files for better review process.

For more information about the MEI Driver and its usage, see:
http://software.intel.com/en-us/manageability-security/
http://software.intel.com/sites/manageability/AMT_Implementation_and_Reference_Guide/default.htm?turl=WordDocuments%2Fconnectingwiththeintelmeidriver.htm




 drivers/char/Kconfig           |   11 +
 drivers/char/Makefile          |    1 +
 drivers/char/mei/Makefile      |   23 +
 drivers/char/mei/hw.h          |  518 ++++++++++++++
 drivers/char/mei/init.c        |  837 ++++++++++++++++++++++
 drivers/char/mei/interface.c   |  478 ++++++++++++
 drivers/char/mei/interface.h   |  134 ++++
 drivers/char/mei/interrupt.c   | 1552 ++++++++++++++++++++++++++++++++++++++++
 drivers/char/mei/iorw.c        |  822 +++++++++++++++++++++
 drivers/char/mei/main.c        | 1466 +++++++++++++++++++++++++++++++++++++
 drivers/char/mei/mei.h         |  166 +++++
 drivers/char/mei/mei_version.h |   35 +
 include/linux/mei.h            |  118 +++
 13 files changed, 6161 insertions(+), 0 deletions(-)


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [RFC PATCH 00/13] Intel(R) MEI Driver

[Greg KH]

On Thu, Feb 10, 2011 at 01:54:54AM -0800, Oren Weil wrote:
> Intel(R) Management Engine Interface (Intel(R) MEI) Driver 
> ==========================================================
> 
> This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

This patch?  What patch, there is no patch here.

You sent out 13 emails with the same exact Subject line, which is not
acceptable at all, and mighty confusing.

> This set of patches is for review purposes; the driver code
> for pull is in the David Woodhouse public git repository:
> http://git.infradead.org/linux-2.6-mei.git

No, we need these as patches, not as a pull request.  Please work on
fixing up your individual patches, that's the only way this is going to
be accepted.

thanks,

greg k-h

Re: [RFC PATCH 00/13] Intel(R) MEI Driver

[Tomas Winkler]

On Thu, Feb 10, 2011 at 7:58 PM, Greg KH <gregkh@suse.de> wrote:
> On Thu, Feb 10, 2011 at 01:54:54AM -0800, Oren Weil wrote:
>> Intel(R) Management Engine Interface (Intel(R) MEI) Driver
>> ==========================================================
>>
>> This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.
>
> This patch?  What patch, there is no patch here.
>
> You sent out 13 emails with the same exact Subject line, which is not
> acceptable at all, and mighty confusing.
>
>> This set of patches is for review purposes; the driver code
>> for pull is in the David Woodhouse public git repository:
>> http://git.infradead.org/linux-2.6-mei.git
>
> No, we need these as patches, not as a pull request.  Please work on
> fixing up your individual patches, that's the only way this is going to
> be accepted.

There was a suggestion of splitting the driver into per file patches
to be reviewable  rather then creating gigantic driver patch.
I personally would prefer the later one  would happy to here any other
suggestions how to split driver.

Thanks
Tomas

Re: [RFC PATCH 00/13] Intel(R) MEI Driver

[Greg KH]

On Thu, Feb 10, 2011 at 08:43:57PM +0200, Tomas Winkler wrote:
> On Thu, Feb 10, 2011 at 7:58 PM, Greg KH <gregkh@suse.de> wrote:
> > On Thu, Feb 10, 2011 at 01:54:54AM -0800, Oren Weil wrote:
> >> Intel(R) Management Engine Interface (Intel(R) MEI) Driver
> >> ==========================================================
> >>
> >> This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.
> >
> > This patch?  What patch, there is no patch here.
> >
> > You sent out 13 emails with the same exact Subject line, which is not
> > acceptable at all, and mighty confusing.
> >
> >> This set of patches is for review purposes; the driver code
> >> for pull is in the David Woodhouse public git repository:
> >> http://git.infradead.org/linux-2.6-mei.git
> >
> > No, we need these as patches, not as a pull request.  Please work on
> > fixing up your individual patches, that's the only way this is going to
> > be accepted.
> 
> There was a suggestion of splitting the driver into per file patches
> to be reviewable  rather then creating gigantic driver patch.
> I personally would prefer the later one  would happy to here any other
> suggestions how to split driver.

Per-file is ok, but just provide proper documentation, don't break the
build, and do it the correct way, like everyone else does every day.
This isn't something new people...

greg k-h

Re: [RFC PATCH 00/13] Intel(R) MEI Driver

[Tomas Winkler]

On Thu, Feb 10, 2011 at 8:47 PM, Greg KH <gregkh@suse.de> wrote:
> On Thu, Feb 10, 2011 at 08:43:57PM +0200, Tomas Winkler wrote:
>> On Thu, Feb 10, 2011 at 7:58 PM, Greg KH <gregkh@suse.de> wrote:
>> > On Thu, Feb 10, 2011 at 01:54:54AM -0800, Oren Weil wrote:
>> >> Intel(R) Management Engine Interface (Intel(R) MEI) Driver
>> >> ==========================================================
>> >>
>> >> This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.
>> >
>> > This patch?  What patch, there is no patch here.
>> >
>> > You sent out 13 emails with the same exact Subject line, which is not
>> > acceptable at all, and mighty confusing.
>> >
>> >> This set of patches is for review purposes; the driver code
>> >> for pull is in the David Woodhouse public git repository:
>> >> http://git.infradead.org/linux-2.6-mei.git
>> >
>> > No, we need these as patches, not as a pull request.  Please work on
>> > fixing up your individual patches, that's the only way this is going to
>> > be accepted.
>>
>> There was a suggestion of splitting the driver into per file patches
>> to be reviewable  rather then creating gigantic driver patch.
>> I personally would prefer the later one  would happy to here any other
>> suggestions how to split driver.
>
> Per-file is ok, but just provide proper documentation, don't break the
> build, and do it the correct way, like everyone else does every day.
> This isn't something new people...

I was actually looking into Documentation/SubmittingDrivers and
SubmittingPatches and there is much suggestion how to handle that.
I'll spell it  just make sure I understand correctly, we do per file
patches with Kconfig + Makefile patch as last in the series so the
build won't break....


Thanks
Tomas