From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
alex.williamson@redhat.com, linux-arm-msm@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR
Date: Wed, 23 Aug 2017 17:51:19 -0400 [thread overview]
Message-ID: <0ef4c01d-75bc-17dc-8926-2f9647cfeec8@codeaurora.org> (raw)
In-Reply-To: <20170823213838.GG8498@bhelgaas-glaptop.roam.corp.google.com>
On 8/23/2017 5:38 PM, Bjorn Helgaas wrote:
> If we increase the timeout, is there still value in adding the
> pci_bus_wait_crs() stuff? I'm not sure there is.
I agree increasing the timeout is more than enough for FLR case.
However, I was considering the wait and pending functions as a utility
that I can reuse towards fixing CRS in other conditions like secondary
bus reset and potentially PM.
I'm planning to have a CRS session in the Linux Plumbers Conference
to talk about CRS use cases.
I was going to follow up this series with secondary bus reset next once
this goes in.
I'm unable to test PM. I can't promise how I fix/test it.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-08-23 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 4:56 [PATCH V12 1/5] PCI: Don't ignore valid response before CRS timeout Sinan Kaya
2017-08-23 4:56 ` [PATCH V12 2/5] PCI: add pci_bus_crs_visibility_pending() function to detect CRS response Sinan Kaya
2017-08-23 4:56 ` [PATCH V12 3/5] PCI: Factor out pci_bus_wait_crs() Sinan Kaya
2017-08-23 4:56 ` [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR Sinan Kaya
2017-08-23 21:38 ` Bjorn Helgaas
2017-08-23 21:51 ` Sinan Kaya [this message]
2017-08-23 22:24 ` Bjorn Helgaas
2017-08-23 4:56 ` [PATCH V12 5/5] PCI: Warn periodically while waiting for device to become ready Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef4c01d-75bc-17dc-8926-2f9647cfeec8@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox