Re: [PATCH v10 0/7] Add AMD ISP4 driver

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[sakari.ailus]

Hi Bin,

On Tue, Apr 07, 2026 at 03:19:20PM +0800, Bin Du wrote:
> Hi Sakari,
> 
> Thank you very much for picking up the series and for updating Patchwork. I
> really appreciate your help and support. It means a lot to us.
> Yes, that's right. <20260303224433.87242-1-kinncj@gmail.com> is no longer
> needed.

The Media CI indeed does check there are no warnings from e.g. static
checkers such as smatch, and this lead to build failure earlier. If the set
would be merged, this same smatch warning would pop up as an error
elsewhere. So in practice it doesn't matter that the smatch warning is a
false positive, it needs to be addressed. You should check smatch is happy
with the updated code.

While you're sending a new version, can you address the new checkpatch.pl
warnings, too? They're trivial.

The best summary is here
<URL:https://gitlab.freedesktop.org/linux-media/media-committers/-/merge_requests/278>
I believe.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[Bin Du]

Many thanks for the feedback, Sakari. I've sent v11 addressing the 
Smatch false positive and the new checkpatch.pl warnings you pointed out:

<URL: https://lore.kernel.org/all/20260506093250.93460-1-Bin.Du@amd.com/>

Could you please take a look when you have a chance?

On 5/6/2026 4:24 AM, sakari.ailus@linux.intel.com wrote:
> Hi Bin,
>
> On Tue, Apr 07, 2026 at 03:19:20PM +0800, Bin Du wrote:
>> Hi Sakari,
>>
>> Thank you very much for picking up the series and for updating Patchwork. I
>> really appreciate your help and support. It means a lot to us.
>> Yes, that's right. <20260303224433.87242-1-kinncj@gmail.com> is no longer
>> needed.
> The Media CI indeed does check there are no warnings from e.g. static
> checkers such as smatch, and this lead to build failure earlier. If the set
> would be merged, this same smatch warning would pop up as an error
> elsewhere. So in practice it doesn't matter that the smatch warning is a
> false positive, it needs to be addressed. You should check smatch is happy
> with the updated code.
>
> While you're sending a new version, can you address the new checkpatch.pl
> warnings, too? They're trivial.
>
> The best summary is here
> <URL:https://gitlab.freedesktop.org/linux-media/media-committers/-/merge_requests/278>
> I believe.
>

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[Bin Du]

Hi Sakari,

I'm not sure which Smatch version is used in Media CI. Here are some 
findings from my local tests for reference.

For v10, I could reproduce the false positive with an older Smatch 
snapshot built from upstream commit 
URL:https://repo.or.cz/smatch.git/commit/bc575c7a0c5c7a2d4fefd0e1d8b0dc9ccacdd1a6, 
which is a pre-1.74 snapshot.

I could not reproduce the same false positive with a newer Smatch 
snapshot based on upstream commit 
URL:https://repo.or.cz/smatch.git/commit/bcc58b9ccf06d28ab6be4f0992bc74f462aa12f8, 
which is a post-1.75 snapshot.

For v11, neither Smatch snapshot reports the warning.

On 5/6/2026 5:41 PM, Bin Du wrote:
> Many thanks for the feedback, Sakari. I've sent v11 addressing the 
> Smatch false positive and the new checkpatch.pl warnings you pointed out:
>
> <URL: https://lore.kernel.org/all/20260506093250.93460-1-Bin.Du@amd.com/>
>
> Could you please take a look when you have a chance?
>
> On 5/6/2026 4:24 AM, sakari.ailus@linux.intel.com wrote:
>> Hi Bin,
>>
>> On Tue, Apr 07, 2026 at 03:19:20PM +0800, Bin Du wrote:
>>> Hi Sakari,
>>>
>>> Thank you very much for picking up the series and for updating 
>>> Patchwork. I
>>> really appreciate your help and support. It means a lot to us.
>>> Yes, that's right. <20260303224433.87242-1-kinncj@gmail.com> is no 
>>> longer
>>> needed.
>> The Media CI indeed does check there are no warnings from e.g. static
>> checkers such as smatch, and this lead to build failure earlier. If 
>> the set
>> would be merged, this same smatch warning would pop up as an error
>> elsewhere. So in practice it doesn't matter that the smatch warning is a
>> false positive, it needs to be addressed. You should check smatch is 
>> happy
>> with the updated code.
>>
>> While you're sending a new version, can you address the new 
>> checkpatch.pl
>> warnings, too? They're trivial.
>>
>> The best summary is here
>> <URL:https://gitlab.freedesktop.org/linux-media/media-committers/-/merge_requests/278> 
>>
>> I believe.
>>

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[sakari.ailus]

Hi Bin,

On Thu, May 07, 2026 at 02:44:32PM +0800, Bin Du wrote:
> Hi Sakari,
> 
> I'm not sure which Smatch version is used in Media CI. Here are some
> findings from my local tests for reference.
> 
> For v10, I could reproduce the false positive with an older Smatch snapshot
> built from upstream commit URL:https://repo.or.cz/smatch.git/commit/bc575c7a0c5c7a2d4fefd0e1d8b0dc9ccacdd1a6,
> which is a pre-1.74 snapshot.
> 
> I could not reproduce the same false positive with a newer Smatch snapshot
> based on upstream commit URL:https://repo.or.cz/smatch.git/commit/bcc58b9ccf06d28ab6be4f0992bc74f462aa12f8,
> which is a post-1.75 snapshot.
> 
> For v11, neither Smatch snapshot reports the warning.

That's nice. Smatch is updated weekly so we should get the new smatch in
soon and you could post a patch to remove the workaround. The code would be
nicer without that.

The patches themselves were merged earlier today to the media committers
tree.

-- 
Regards,

Sakari Ailus

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[sakari.ailus]

Hi Bin,

On Fri, May 08, 2026 at 10:52:55AM +0800, Bin Du wrote:
> Many thanks for the update and for merging the series, Sakari. Once the
> newer Smatch lands in CI, I'll send a follow-up patch to remove the
> workaround. BTW, do you happen to know how to check which Smatch snapshot
> Media CI is currently using?

How about posting a patch next week? :-)

Cc Ricardo, too.

-- 
Regards,

Sakari Ailus

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[Bin Du]

Hi Sakari,

Sure, I'll send a follow-up patch next week and Cc Ricardo as well.

On 5/9/2026 5:30 AM, sakari.ailus@linux.intel.com wrote:
> Hi Bin,
>
> On Fri, May 08, 2026 at 10:52:55AM +0800, Bin Du wrote:
>> Many thanks for the update and for merging the series, Sakari. Once the
>> newer Smatch lands in CI, I'll send a follow-up patch to remove the
>> workaround. BTW, do you happen to know how to check which Smatch snapshot
>> Media CI is currently using?
> How about posting a patch next week? 🙂
>
> Cc Ricardo, too.

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[Ricardo Ribalda]

Hi,

You can check what media-ci uses by:

$ podman pull registry.freedesktop.org/linux-media/media-ci/static:latest
$ podman run --rm -it
registry.freedesktop.org/linux-media/media-ci/static:latest
# cd /media-ci/third_party/
# git describe HEAD
v0.5.0-9187-g9dcab8cc

Regards!

(you can also use docker instead of podman)

On Sat, 9 May 2026 at 04:00, Bin Du <Bin.Du@amd.com> wrote:
>
> Hi Sakari,
>
> Sure, I'll send a follow-up patch next week and Cc Ricardo as well.
>
> On 5/9/2026 5:30 AM, sakari.ailus@linux.intel.com wrote:
> > Hi Bin,
> >
> > On Fri, May 08, 2026 at 10:52:55AM +0800, Bin Du wrote:
> >> Many thanks for the update and for merging the series, Sakari. Once the
> >> newer Smatch lands in CI, I'll send a follow-up patch to remove the
> >> workaround. BTW, do you happen to know how to check which Smatch snapshot
> >> Media CI is currently using?
> > How about posting a patch next week? 🙂
> >
> > Cc Ricardo, too.



-- 
Ricardo Ribalda

Re: [PATCH v10 0/7] Add AMD ISP4 driver

[Bin Du]

Hi Ricardo,

Thanks, this was very helpful.

In /media-ci/third_party, `git describe HEAD` fails with:

root@a3a5d0a55d48:/media-ci/third_party# git describe HEAD
fatal: not a git repository (or any of the parent directories): .git

So I tried a bit further. Under /media-ci/third_party/smatch, I get:

# git describe --tags --always --dirty
1.75-3-g9dcab8cc
# ./smatch --version
v0.5.0-9187-g9dcab8cc

So I assume /media-ci/third_party/smatch is the right place to check the
Smatch snapshot used by media-ci.

Regards,
Bin

On 5/10/2026 7:49 AM, Ricardo Ribalda wrote:
> Hi,
>
> You can check what media-ci uses by:
>
> $ podman pull registry.freedesktop.org/linux-media/media-ci/static:latest
> $ podman run --rm -it
> registry.freedesktop.org/linux-media/media-ci/static:latest
> # cd /media-ci/third_party/
> # git describe HEAD
> v0.5.0-9187-g9dcab8cc
>
> Regards!
>
> (you can also use docker instead of podman)
>
> On Sat, 9 May 2026 at 04:00, Bin Du <Bin.Du@amd.com> wrote:
>> Hi Sakari,
>>
>> Sure, I'll send a follow-up patch next week and Cc Ricardo as well.
>>
>> On 5/9/2026 5:30 AM, sakari.ailus@linux.intel.com wrote:
>>> Hi Bin,
>>>
>>> On Fri, May 08, 2026 at 10:52:55AM +0800, Bin Du wrote:
>>>> Many thanks for the update and for merging the series, Sakari. Once the
>>>> newer Smatch lands in CI, I'll send a follow-up patch to remove the
>>>> workaround. BTW, do you happen to know how to check which Smatch snapshot
>>>> Media CI is currently using?
>>> How about posting a patch next week? 🙂
>>>
>>> Cc Ricardo, too.
>
>