From: Thomas Hood <jdthood@mail.com>
To: "J . A . Magallon" <jamagallon@able.es>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.10-ac11 parport_pc.c bugfix
Date: 11 Oct 2001 09:52:27 -0400 [thread overview]
Message-ID: <1002808349.10317.7.camel@thanatos> (raw)
In-Reply-To: <20011011154039.C3904@werewolf.able.es>
In-Reply-To: <1002766826.7434.38.camel@thanatos> <20011011154039.C3904@werewolf.able.es>
I guess the question is: Which way is more portable? Is
"(unsigned long)-1" liable to turn out as something other than
~0U?
If your way of expressing it is more portable then we should
make the change ... BOTH in pnp_bios.c and in parport_pc.c .
Opinions?
--
Thomas
On Thu, 2001-10-11 at 09:40, J . A . Magallon wrote:
>
> On 20011011 Thomas Hood wrote:
> > } else {
> >- if ( dev->irq_resource[0].start == -1 ) {
> >+ if ( dev->irq_resource[0].start == (unsigned long)-1 ) {
> ^^^^^^^^^ ^
> Uh ?
>
> Perhaps I miss some black magic in kernel programming, but could not this
> be written much cleaner like
>
> >+ if ( dev->irq_resource[0].start == ~0U ) {
>
> --
> J.A. Magallon # Let the source be with you...
> mailto:jamagallon@able.es
> Mandrake Linux release 8.2 (Cooker) for i586
> Linux werewolf 2.4.10-ac11-beo #2 SMP Thu Oct 11 02:41:04 CEST 2001 i686
>
next prev parent reply other threads:[~2001-10-11 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-11 2:20 [PATCH] 2.4.10-ac11 parport_pc.c bugfix Thomas Hood
2001-10-11 13:40 ` J . A . Magallon
2001-10-11 13:52 ` Thomas Hood [this message]
2001-10-11 14:52 ` Bob McElrath
2001-10-11 22:41 ` bill davidsen
2001-10-12 1:45 ` Thomas Hood
-- strict thread matches above, loose matches on Subject: below --
2001-10-11 18:35 J.D. Hood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1002808349.10317.7.camel@thanatos \
--to=jdthood@mail.com \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox