public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J . A . Magallon" <jamagallon@able.es>
To: Thomas Hood <jdthood@mail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.10-ac11 parport_pc.c bugfix
Date: Thu, 11 Oct 2001 15:40:39 +0200	[thread overview]
Message-ID: <20011011154039.C3904@werewolf.able.es> (raw)
In-Reply-To: <1002766826.7434.38.camel@thanatos>
In-Reply-To: <1002766826.7434.38.camel@thanatos>; from jdthood@mail.com on Thu, Oct 11, 2001 at 04:20:23 +0200


On 20011011 Thomas Hood wrote:
> 	} else {
>-		if ( dev->irq_resource[0].start == -1 ) {
>+		if ( dev->irq_resource[0].start == (unsigned long)-1 ) {
                                                   ^^^^^^^^^      ^
Uh ?

Perhaps I miss some black magic in kernel programming, but could not this
be written much cleaner like

>+		if ( dev->irq_resource[0].start == ~0U ) {

-- 
J.A. Magallon                           #  Let the source be with you...        
mailto:jamagallon@able.es
Mandrake Linux release 8.2 (Cooker) for i586
Linux werewolf 2.4.10-ac11-beo #2 SMP Thu Oct 11 02:41:04 CEST 2001 i686

  reply	other threads:[~2001-10-11 13:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-11  2:20 [PATCH] 2.4.10-ac11 parport_pc.c bugfix Thomas Hood
2001-10-11 13:40 ` J . A . Magallon [this message]
2001-10-11 13:52   ` Thomas Hood
2001-10-11 14:52     ` Bob McElrath
2001-10-11 22:41     ` bill davidsen
2001-10-12  1:45       ` Thomas Hood
  -- strict thread matches above, loose matches on Subject: below --
2001-10-11 18:35 J.D. Hood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011011154039.C3904@werewolf.able.es \
    --to=jamagallon@able.es \
    --cc=jdthood@mail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox