* [PATCH] thermal: exynos: fix ordering in exynos_tmu_remove()
@ 2014-07-08 13:09 Bartlomiej Zolnierkiewicz
2014-07-09 2:46 ` amit daniel kachhap
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-07-08 13:09 UTC (permalink / raw)
To: Eduardo Valentin
Cc: Zhang Rui, Amit Daniel Kachhap, Kyungmin Park, linux-samsung-soc,
linux-pm, linux-kernel
It might not be a problem currently but unregister/uninitialize things
in the reverse order that they are registered/initialized.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/thermal/samsung/exynos_tmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index d7ca9f4..6243ba0 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -759,10 +759,10 @@ static int exynos_tmu_remove(struct platform_device *pdev)
{
struct exynos_tmu_data *data = platform_get_drvdata(pdev);
- exynos_tmu_control(pdev, false);
-
exynos_unregister_thermal(data->reg_conf);
+ exynos_tmu_control(pdev, false);
+
clk_unprepare(data->clk);
if (!IS_ERR(data->clk_sec))
clk_unprepare(data->clk_sec);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal: exynos: fix ordering in exynos_tmu_remove()
2014-07-08 13:09 [PATCH] thermal: exynos: fix ordering in exynos_tmu_remove() Bartlomiej Zolnierkiewicz
@ 2014-07-09 2:46 ` amit daniel kachhap
0 siblings, 0 replies; 2+ messages in thread
From: amit daniel kachhap @ 2014-07-09 2:46 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Eduardo Valentin, Zhang Rui, Kyungmin Park,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
On Tue, Jul 8, 2014 at 6:39 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> It might not be a problem currently but unregister/uninitialize things
> in the reverse order that they are registered/initialized.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Changes look fine,
Reviewed-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index d7ca9f4..6243ba0 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -759,10 +759,10 @@ static int exynos_tmu_remove(struct platform_device *pdev)
> {
> struct exynos_tmu_data *data = platform_get_drvdata(pdev);
>
> - exynos_tmu_control(pdev, false);
> -
> exynos_unregister_thermal(data->reg_conf);
>
> + exynos_tmu_control(pdev, false);
> +
> clk_unprepare(data->clk);
> if (!IS_ERR(data->clk_sec))
> clk_unprepare(data->clk_sec);
> --
> 1.8.2.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-09 2:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-08 13:09 [PATCH] thermal: exynos: fix ordering in exynos_tmu_remove() Bartlomiej Zolnierkiewicz
2014-07-09 2:46 ` amit daniel kachhap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox