From: Robert Love <rml@tech9.net>
To: Bongani <bonganilinux@mweb.co.za>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] Compilation error on 2.5.8
Date: 15 Apr 2002 19:24:29 -0400 [thread overview]
Message-ID: <1018913070.3399.37.camel@phantasy> (raw)
In-Reply-To: <1018913727.2688.118.camel@localhost.localdomain>
On Mon, 2002-04-15 at 19:34, Bongani wrote:
> Does this also look cleaner ?
> -static inline void setup_per_cpu_areas(void)
> -{
> -}
> +
> +#define setup_per_cpu_areas() do { } while(0)
> +
Personally yes, but others would disagree.
In fact, if we use a define setup_per_cpu_areas can not be used outside
of this compilation unit. Right now this looks to be the case, but if
something other than init/main.c wanted to use setup_per_cpu_areas we
would need to make the code an actual function or put the define in a
header file.
Since either case should optimize away, maybe we should make it a static
inline in both cases, since that is the authors original preference ...
Robert Love
next prev parent reply other threads:[~2002-04-15 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-15 22:53 [Patch] Compilation error on 2.5.8 Bongani
2002-04-15 22:45 ` Robert Love
2002-04-15 23:34 ` Bongani
2002-04-15 23:24 ` Robert Love [this message]
2002-04-16 4:57 ` Bongani
2002-04-16 4:48 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1018913070.3399.37.camel@phantasy \
--to=rml@tech9.net \
--cc=bonganilinux@mweb.co.za \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox