Re: [Patch] Compilation error on 2.5.8

[Bongani <bonganilinux@mweb.co.za>]

On Tue, 2002-04-16 at 01:24, Robert Love wrote:
> On Mon, 2002-04-15 at 19:34, Bongani wrote:
> 
> > Does this also look cleaner ?
> 
> > -static inline void setup_per_cpu_areas(void)
> > -{
> > -}
> > +
> > +#define setup_per_cpu_areas()  do { } while(0)
> > +
> 
> Personally yes, but others would disagree.
> 
> In fact, if we use a define setup_per_cpu_areas can not be used outside
> of this compilation unit.  Right now this looks to be the case, but if
> something other than init/main.c wanted to use setup_per_cpu_areas we
> would need to make the code an actual function or put the define in a
> header file.
> 
> Since either case should optimize away, maybe we should make it a static
> inline in both cases, since that is the authors original preference ...
> 
> 	Robert Love
> 

Ok, so this patch should be fine then

--- init/main.c Tue Apr 16 06:52:20 2002
+++ init/main.c_new     Tue Apr 16 06:55:17 2002
@@ -272,6 +272,10 @@
 #define smp_init()     do { } while (0)
 #endif

+static inline void setup_per_cpu_areas(void)
+{
+}
+
 #else

 #ifdef __GENERIC_PER_CPU
@@ -297,9 +301,11 @@
        }
 }
 #else
+
 static inline void setup_per_cpu_areas(void)
 {
 }
+
 #endif /* !__GENERIC_PER_CPU */

 /* Called by boot processor to activate the rest. */