public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
	Kristis Makris <devcore@freeuk.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] niceness magic numbers, 2.4.20-pre11
Date: 23 Oct 2002 15:52:52 -0400	[thread overview]
Message-ID: <1035402772.3171.1550.camel@phantasy> (raw)
In-Reply-To: <1035360961.4033.0.camel@irongate.swansea.linux.org.uk>

On Wed, 2002-10-23 at 04:16, Alan Cox wrote:

> On Wed, 2002-10-23 at 07:37, Randy.Dunlap wrote:
> > --- ./include/linux/resource.h.nice	Tue Jun 18 20:10:36 2002
> > +++ ./include/linux/resource.h	Sat Oct 19 13:55:10 2002
> > @@ -43,7 +43,7 @@
> >  };
> > 
> >  #define	PRIO_MIN	(-20)
> > -#define	PRIO_MAX	20
> > +#define	PRIO_MAX	19
> 
> I suspect this isnt correct

Agreed.  Its not.

It should remain 20 and places that truly want 19 should do PRIO_MAX-1.

The idea of cleaning up the magic numbers is fine, otherwise..

	Robert Love


  reply	other threads:[~2002-10-23 19:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-23  4:59 [PATCH] niceness magic numbers, 2.4.20-pre11 Kristis Makris
2002-10-23  6:37 ` Randy.Dunlap
2002-10-23  8:16   ` Alan Cox
2002-10-23 19:52     ` Robert Love [this message]
2002-10-23 23:50       ` [PATCH] niceness magic numbers, 2.5.44 now Randy.Dunlap
2002-10-24  0:11         ` Robert Love
2002-10-24  3:22       ` [PATCH] niceness magic numbers, 2.4.20-pre11 Kristis Makris
2002-10-24  3:32         ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1035402772.3171.1550.camel@phantasy \
    --to=rml@tech9.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=devcore@freeuk.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox