* Re: [PATCH] Hidden SMBus bridge on Toshiba Tecra M2
@ 2005-06-21 4:40 Kenneth Parrish
0 siblings, 0 replies; 6+ messages in thread
From: Kenneth Parrish @ 2005-06-21 4:40 UTC (permalink / raw)
To: linux-kernel
-=> Daniele Gaffuri wrote to Greg KH <=-
here it looks ...
DG> }=0A=
DG> + if (dev->device =3D=3D
DG> PCI_DEVICE_ID_INTEL_82855PM_HB)=0A= +
DG> switch(dev->subsystem_device) {=0A= + case
DG> 0x0001: /* Toshiba Tecra M2 */=0A= +
DG> asus_hides_smbus =3D 1;=0A= + }=0A=
DG> } else if (unlikely(dev->subsystem_vendor =3D=3D =
DG> PCI_VENDOR_ID_SAMSUNG)) {=0A=
DG> if (dev->device =3D=3D
DG> PCI_DEVICE_ID_INTEL_82855PM_HB)=0A=
DG> switch(dev->subsystem_device) {=0A=
--- MultiMail/Linux v0.46
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] Hidden SMBus bridge on Toshiba Tecra M2
@ 2005-06-17 22:36 Daniele Gaffuri
2005-06-17 22:49 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Daniele Gaffuri @ 2005-06-17 22:36 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh
Here's a trivial patch, against 2.6.12-rc6, to unhide SMBus on Toshiba
Centrino laptops using Intel 82855PM chipset.
--- linux-2.6.12-rc6/drivers/pci/quirks.c 2005-06-17
23:49:32.000000000 +0200
+++ linux/drivers/pci/quirks.c 2005-06-18 00:06:45.000000000 +0200
@@ -822,6 +822,11 @@
case 0x0001: /* Toshiba Satellite A40 */
asus_hides_smbus = 1;
}
+ if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
+ switch(dev->subsystem_device) {
+ case 0x0001: /* Toshiba Tecra M2 */
+ asus_hides_smbus = 1;
+ }
} else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG))
{
if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
switch(dev->subsystem_device) {
Tested on Toshiba Tecra M2.
Daniele
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Hidden SMBus bridge on Toshiba Tecra M2
2005-06-17 22:36 Daniele Gaffuri
@ 2005-06-17 22:49 ` Greg KH
2005-06-18 0:50 ` Daniele Gaffuri
2005-06-18 14:18 ` Daniele Gaffuri
0 siblings, 2 replies; 6+ messages in thread
From: Greg KH @ 2005-06-17 22:49 UTC (permalink / raw)
To: Daniele Gaffuri; +Cc: linux-kernel
On Sat, Jun 18, 2005 at 12:36:18AM +0200, Daniele Gaffuri wrote:
> Here's a trivial patch, against 2.6.12-rc6, to unhide SMBus on Toshiba
> Centrino laptops using Intel 82855PM chipset.
Your patch is linewrapped, and missing a Signed-off-by: line. Care to
redo it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Hidden SMBus bridge on Toshiba Tecra M2
2005-06-17 22:49 ` Greg KH
@ 2005-06-18 0:50 ` Daniele Gaffuri
2005-06-18 14:18 ` Daniele Gaffuri
1 sibling, 0 replies; 6+ messages in thread
From: Daniele Gaffuri @ 2005-06-18 0:50 UTC (permalink / raw)
To: 'Greg KH'; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Greg KH wrote:
> On Sat, Jun 18, 2005 at 12:36:18AM +0200, Daniele Gaffuri wrote:
>> Here's a trivial patch, against 2.6.12-rc6, to unhide SMBus on
>> Toshiba Centrino laptops using Intel 82855PM chipset.
>
> Your patch is linewrapped, and missing a Signed-off-by: line. Care to
> redo it?
>
> thanks,
>
> greg k-h
Sorry. Didn't realize. Trying to attach to avoid it.
Trivial patch, against 2.6.12-rc6, to unhide SMBus on Toshiba Centrino
laptops using Intel 82855PM chipset
Signed-off-by: Daniele Gaffuri <d.gaffuri@reply.it>
Daniele
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 625 bytes --]
--- linux-2.6.12-rc6/drivers/pci/quirks.c 2005-06-17 23:49:32.000000000 +0200
+++ linux/drivers/pci/quirks.c 2005-06-18 00:06:45.000000000 +0200
@@ -822,6 +822,11 @@
case 0x0001: /* Toshiba Satellite A40 */
asus_hides_smbus = 1;
}
+ if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
+ switch(dev->subsystem_device) {
+ case 0x0001: /* Toshiba Tecra M2 */
+ asus_hides_smbus = 1;
+ }
} else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG)) {
if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
switch(dev->subsystem_device) {
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] Hidden SMBus bridge on Toshiba Tecra M2
2005-06-17 22:49 ` Greg KH
2005-06-18 0:50 ` Daniele Gaffuri
@ 2005-06-18 14:18 ` Daniele Gaffuri
2005-06-18 14:51 ` Jean Delvare
1 sibling, 1 reply; 6+ messages in thread
From: Daniele Gaffuri @ 2005-06-18 14:18 UTC (permalink / raw)
To: 'Greg KH'; +Cc: linux-kernel
Greg KH wrote:
> On Sat, Jun 18, 2005 at 12:36:18AM +0200, Daniele Gaffuri wrote:
>> Here's a trivial patch, against 2.6.12-rc6, to unhide SMBus on
>> Toshiba Centrino laptops using Intel 82855PM chipset.
>
> Your patch is linewrapped, and missing a Signed-off-by: line. Care to
> redo it?
>
> thanks,
>
> greg k-h
Please, excuse me if you can, the second one was exactly like the first.
This should be OK, in the meanwhile I've redone with 2.6.12.
Patch against 2.6.12 to unhide SMBus on Toshiba Centrino laptops using Intel 82855PM chipset.
Tested on Toshiba Tecra M2.
Signed-off-by: Daniele Gaffuri <d.gaffuri@reply.it>
--- linux-2.6.12/drivers/pci/quirks.c.orig 2005-06-17 21:48:29.000000000 +0200
+++ linux-2.6.12/drivers/pci/quirks.c 2005-06-18 15:03:49.000000000 +0200
@@ -819,6 +819,11 @@ static void __init asus_hides_smbus_host
case 0x0001: /* Toshiba Satellite A40 */
asus_hides_smbus = 1;
}
+ if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
+ switch(dev->subsystem_device) {
+ case 0x0001: /* Toshiba Tecra M2 */
+ asus_hides_smbus = 1;
+ }
} else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG)) {
if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
switch(dev->subsystem_device) {
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-06-21 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-21 4:40 [PATCH] Hidden SMBus bridge on Toshiba Tecra M2 Kenneth Parrish
-- strict thread matches above, loose matches on Subject: below --
2005-06-17 22:36 Daniele Gaffuri
2005-06-17 22:49 ` Greg KH
2005-06-18 0:50 ` Daniele Gaffuri
2005-06-18 14:18 ` Daniele Gaffuri
2005-06-18 14:51 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox