Unable to build tgafb.c in 2.6.0-test5 due to undefined color_table

Unable to build tgafb.c in 2.6.0-test5 due to undefined color_table

[Stephen Torri]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

I was trying to compile the tga framebuffer driver but there was a
compiler error saying that color_table was not defined. I grepped
through the drivers/video and include/video directories and did not find
a declaration. Was there a header file not included or code missing from
the driver? 

The result of doing 'make vmlinux':

alpha:/usr/src/linux-2.6.0-test5# make vmlinux
make[1]: `arch/alpha/kernel/asm-offsets.s' is up to date.
  CHK     include/linux/compile.h
  CC      drivers/video/tgafb.o
drivers/video/tgafb.c: In function `tgafb_set_par':
drivers/video/tgafb.c:233: `color_table' undeclared (first use in this
function)drivers/video/tgafb.c:233: (Each undeclared identifier is
reported only once
drivers/video/tgafb.c:233: for each function it appears in.)
drivers/video/tgafb.c:234: `default_red' undeclared (first use in this
function)drivers/video/tgafb.c:236: `default_grn' undeclared (first use
in this function)drivers/video/tgafb.c:238: `default_blu' undeclared
(first use in this function)make[2]: *** [drivers/video/tgafb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

Stephen
-- 
Stephen Torri
GPG Key: http://www.cs.wustl.edu/~storri/storri.asc

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Unable to build tgafb.c in 2.6.0-test5 due to undefined color_table

["Alexey Dobriyan"]

> I was trying to compile the tga framebuffer driver but there was a > compiler error saying that color_table was not defined. I grepped 
> through the drivers/video and include/video directories and did not > find a declaration. Was there a header file not included or code 
> missing from the driver?

This should fix the problem.

Alexey

diff -urN a/drivers/video/tgafb.c b/drivers/video/tgafb.c
--- a/drivers/video/tgafb.c	2003-09-08 23:50:16.000000000 +0400
+++ b/drivers/video/tgafb.c	2003-09-16 13:46:46.000000000 +0400
@@ -22,6 +22,7 @@
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/fb.h>
+#include <linux/selection.h>
 #include <linux/pci.h>
 #include <asm/io.h>
 #include <video/tgafb.h>