From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: dhowells@redhat.com, Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Mike Marshall <hubcap@omnibond.com>, Gao Xiang <xiang@kernel.org>,
linux-afs@lists.infradead.org,
v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org,
linux-erofs@lists.ozlabs.org, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: mainline build failure due to 6c77676645ad ("iov_iter: Fix iter_xarray_get_pages{,_alloc}()")
Date: Mon, 13 Jun 2022 10:19:18 +0100 [thread overview]
Message-ID: <1075696.1655111958@warthog.procyon.org.uk> (raw)
In-Reply-To: <YqSQ++8UnEW0AJ2y@zeniv-ca.linux.org.uk>
Al Viro <viro@zeniv.linux.org.uk> wrote:
> The reason we can't overflow on multiplication there, BTW, is that we have
> nr <= count, and count has come from weirdly open-coded
> DIV_ROUND_UP(size + offset, PAGE_SIZE)
> IMO we'd better make it explicit, so how about the following:
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
It seems reasonable.
Reviewed-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2022-06-13 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 10:45 mainline build failure due to 6c77676645ad ("iov_iter: Fix iter_xarray_get_pages{,_alloc}()") Sudip Mukherjee
2022-06-11 10:55 ` Sudip Mukherjee
2022-06-11 12:12 ` Al Viro
2022-06-11 12:37 ` Al Viro
2022-06-11 12:56 ` Al Viro
2022-06-11 14:00 ` Guenter Roeck
2022-06-11 15:01 ` Al Viro
2022-06-11 15:39 ` Al Viro
2022-06-11 23:16 ` Sudip Mukherjee
2022-06-13 9:19 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1075696.1655111958@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox