From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: David Eger <eger@theboonies.us>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.3-rc3 radeonfb: Problems with new (and old) driver
Date: Tue, 17 Feb 2004 10:31:45 +1100 [thread overview]
Message-ID: <1076974304.1046.102.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.58.0402161503490.30742@home.osdl.org>
> Yes. I agree. The naming is crap. We're not blanking, we're changing
> state.
>
> But it's not a mode switch either - _sometimes_ it's a mode switch, but
> sometimes the state change is that we're switching to another backing
> store (ie a VC switch) but with the same mode.
>
> So _logically_ the interface should be more of a "con_notify_change()"
> one, with a bitmap of which states have changed (where "graphics vs text"
> is just one set of states - resultion is another, VC backing store is one,
> etc etc).
>
> (I call it "notify_change()", because we have exactly that in VFS terms,
> where the inode change descriptor has an attribute table and a "valid"
> bitmap).
Ok, if it's ok to delay it to 2.6.4, i'd prefer going all the way trough
calling it properly and passing the proper "state" flags instead of
hacking more on broken blank/unblank semantics. It can stay in -mm for
a while if we want enough testing.
Ben.
next prev parent reply other threads:[~2004-02-16 23:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.50L0.0402160411260.2959-100000@rosencrantz.theboonies.us>
2004-02-16 4:01 ` 2.6.3-rc3 radeonfb: Problems with new (and old) driver Benjamin Herrenschmidt
2004-02-16 17:56 ` Linus Torvalds
2004-02-16 21:50 ` Benjamin Herrenschmidt
2004-02-16 22:13 ` Linus Torvalds
2004-02-16 22:18 ` Benjamin Herrenschmidt
2004-02-16 22:30 ` Linus Torvalds
2004-02-16 22:57 ` Benjamin Herrenschmidt
2004-02-16 23:09 ` Linus Torvalds
2004-02-16 23:31 ` Benjamin Herrenschmidt [this message]
2004-02-16 23:49 ` Linus Torvalds
2004-02-17 0:04 ` Benjamin Herrenschmidt
2004-02-15 6:16 [PATCH] Remove debug cruft from via-pmu.c driver Benjamin Herrenschmidt
2004-02-15 18:02 ` 2.6.3-rc3 radeonfb: Problems with new (and old) driver Mike Houston
2004-02-15 21:01 ` Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1076974304.1046.102.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=eger@theboonies.us \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox