From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>, "David S. Miller" <davem@redhat.com>
Subject: Re: Fix silly thinko in sungem network driver.
Date: Sat, 21 Feb 2004 11:19:13 +1100 [thread overview]
Message-ID: <1077322751.10864.3.camel@gaston> (raw)
In-Reply-To: <1077322322.9623.34.camel@gaston>
> Here it is:
>
> .../...
And here's the version without the typo
(I shall not code before having breakfast...)
--- linux-2.5/drivers/net/sungem.c 2004-02-21 11:10:33.390479384 +1100
+++ linuxppc-2.5-benh/drivers/net/sungem.c 2004-02-21 11:18:23.396027680 +1100
@@ -1837,7 +1837,8 @@
* thresholds (and Apple bug fixes don't exist)
*/
if (!(readl(gp->regs + GREG_CFG) & GREG_CFG_IBURST)) {
- cfg = ((2 << 1) & GREG_CFG_TXDMALIM);
+ cfg &= ~(GREG_CFG_TXDMALIM | GREG_CFG_RXDMALIM);
+ cfg |= ((2 << 1) & GREG_CFG_TXDMALIM);
cfg |= ((8 << 6) & GREG_CFG_RXDMALIM);
writel(cfg, gp->regs + GREG_CFG);
}
next prev parent reply other threads:[~2004-02-21 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200402202307.i1KN7GBR003938@hera.kernel.org>
2004-02-21 0:04 ` Fix silly thinko in sungem network driver Benjamin Herrenschmidt
2004-02-21 0:12 ` Benjamin Herrenschmidt
2004-02-21 0:19 ` Benjamin Herrenschmidt [this message]
2004-02-21 0:23 ` David S. Miller
2004-02-21 0:24 ` Benjamin Herrenschmidt
2004-02-21 0:32 ` Benjamin Herrenschmidt
2004-02-21 0:34 ` David S. Miller
2004-02-21 0:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077322751.10864.3.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox