From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "David S. Miller" <davem@redhat.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: Fix silly thinko in sungem network driver.
Date: Sat, 21 Feb 2004 11:32:54 +1100 [thread overview]
Message-ID: <1077323574.10862.12.camel@gaston> (raw)
In-Reply-To: <1077323090.10877.9.camel@gaston>
And some more data:
Apple .h says:
#define kConfiguration_Infinite_Burst 0x00000001 // for Tx only
#define kConfiguration_RonPaulBit 0x00000800 // for pci reads at end of infinite burst, next command is memory read multiple
#define kConfiguration_EnableBug2Fix 0x00001000 // fix Rx hang after overflow
And the OF firmware (forth) driver does:
config rl@ 801 or config rl!
Which is interesting, that is it sets the RonPaulBit and the Infinite
Burst bit, and doesn't test the result...
Linus, does your G5 infinite burst bit sticks at all ? I think the
idea is that _older_ apple ones didn't have infinite burst, while newer
(G5) ones do, but also need the bug fix bits.
Which means the code Linus has is ok (without my latest patch).
Ben.
next prev parent reply other threads:[~2004-02-21 0:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200402202307.i1KN7GBR003938@hera.kernel.org>
2004-02-21 0:04 ` Fix silly thinko in sungem network driver Benjamin Herrenschmidt
2004-02-21 0:12 ` Benjamin Herrenschmidt
2004-02-21 0:19 ` Benjamin Herrenschmidt
2004-02-21 0:23 ` David S. Miller
2004-02-21 0:24 ` Benjamin Herrenschmidt
2004-02-21 0:32 ` Benjamin Herrenschmidt [this message]
2004-02-21 0:34 ` David S. Miller
2004-02-21 0:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077323574.10862.12.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox