Re: [announce] HVCS for inclusion in 2.6 tree

[Ryan Arnold <rsa@us.ibm.com>]

On Sat, 2004-07-17 at 21:00, Paul Mackerras wrote:
> The arch/ppc64 stuff mostly looks OK - however I would prefer that you
> created a new arch/ppc64/kernel/hvcs.c (and include/asm-ppc64/hvcs.h)
> rather than tripling the size of the existing hvconsole.c.  There are
> a couple of whitespace nits (missing space after "if" in a couple of
> places), and this:

Paul, Thanks for the comments.  Maybe it would be better to avoid
repetition of file names and create include/asm-ppc64/hvcserver.h and
arch/ppc64/kernel/hvcserver.c?

> > +#define HVCS_LONG_INVALID	0xFFFFFFFFFFFFFFFF
> 
> would look better as either ~0UL or -1L (and I don't see why it really
> needs a #define).

Well, since the assigned variables are "unsigned long" I suppose ~OUL
would be more appropriate.

Ryan S. Arnold
IBM Corporation, Linux Technology Center