From: Ryan Arnold <rsa@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [announce] HVCS for inclusion in 2.6 tree
Date: Mon, 26 Jul 2004 09:41:45 -0500 [thread overview]
Message-ID: <1090847830.3161.12.camel@localhost> (raw)
In-Reply-To: <20040722185733.2806e615.akpm@osdl.org>
On Thu, 2004-07-22 at 20:57, Andrew Morton wrote:
> A little stylistic thing:
>
> > + struct hvcs_struct *hvcsd = (struct hvcs_struct *)tty->driver_data;
> > + struct hvcs_struct *hvcsd = (struct hvcs_struct *)tty->driver_data;
> > + struct hvcs_struct *hvcsd = (struct hvcs_struct *)dev_instance;
>
> It's not necessary to add a typecast when assigning to and from a void*.
> In fact, it's harmful: if someone were to later change, say,
> tty->driver_data to a `struct foo *', your typecast will suppress the
> warning which we would very much like to receive.
Easy enough to fix. Thanks, I'll take care of it.
Ryan S. Arnold
IBM Linux Technology Center
next prev parent reply other threads:[~2004-07-26 19:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 15:42 [announce] HVCS for inclusion in 2.6 tree Ryan Arnold
2004-07-18 2:00 ` Paul Mackerras
2004-07-19 15:54 ` Ryan Arnold
2004-07-22 20:26 ` Ryan Arnold
2004-07-23 1:57 ` Andrew Morton
2004-07-26 14:41 ` Ryan Arnold [this message]
2004-07-23 2:16 ` Andrew Morton
2004-07-27 20:08 ` [announce][draft3] " Ryan Arnold
2004-07-27 22:50 ` Randy.Dunlap
2004-07-28 16:39 ` Ryan Arnold
2004-07-28 20:12 ` Randy.Dunlap
2004-07-28 20:18 ` [announce][draft4] " Ryan Arnold
2004-07-29 17:41 ` Jeff Garzik
2004-08-02 14:24 ` Ryan Arnold
2004-07-28 20:36 ` [announce][draft3] " Paul Mackerras
2004-07-28 17:00 ` Ryan Arnold
2004-07-27 23:02 ` Randy.Dunlap
2004-07-23 2:21 ` [announce] " Andrew Morton
2004-07-26 12:57 ` Ryan Arnold
2004-07-23 2:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1090847830.3161.12.camel@localhost \
--to=rsa@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox