From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andi Kleen <ak@muc.de>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
khawar.chaudhry@amd.com, reeja.john@amd.com
Subject: Re: [PATCH] amd8111e endian & barrier fixes
Date: Sat, 09 Oct 2004 11:06:13 +1000 [thread overview]
Message-ID: <1097283973.3605.11.camel@gaston> (raw)
In-Reply-To: <m3u0t5a0u1.fsf@averell.firstfloor.org>
On Fri, 2004-10-08 at 21:47, Andi Kleen wrote:
> It's basically impossible to review the patch properly because
> of that change. Can you please separate the arbitary white space
> change into a different patch?
Hrm... I think you are doing too much here ;) The change concerns only a
single function and is still quite readable :) But anyways, I'll
eventually do that next week.
> Also I would suggest you send the patch to the driver
> maintainers for review first (cc'ed)
Well, I would have done if any maintainer email was in the source code,
which isn't the case, but thanks for providing them :)
> >From a quick look the change to clear the ring rx flags completely
> instead of clearing the bit looks bogus. Why did you not just add a
> endian conversion there?
Because the bits mask was ... 0 :)
> I can test it when it's properly reviewd.
Sure. No hurry.
Ben
next prev parent reply other threads:[~2004-10-09 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2MWTy-5mO-5@gated-at.bofh.it>
2004-10-08 11:47 ` [PATCH] amd8111e endian & barrier fixes Andi Kleen
2004-10-09 1:06 ` Benjamin Herrenschmidt [this message]
2004-10-08 6:41 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097283973.3605.11.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ak@muc.de \
--cc=jgarzik@pobox.com \
--cc=khawar.chaudhry@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reeja.john@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox