Re: rwsem, gcc3 again

Re: rwsem, gcc3 again

[eccesys]

David,
I am using the gcc-3.0 snapshot of 14.5.2001 from codesourcery (i686 binary).
I have now tried to mimic CPU=386 behaviour (patch posted yesterday night)
and it compiles (just sound fails), by exchanging y and n in
CONFIG_RWSEM_GENERIC_SPINLOCK and CONFIG_RWSEM_XCHGADD_ALGORITHM.

Thanks for your patience, all listening...

-mirabilos
-- 
by telnet

Re: rwsem, gcc3 again

[Andrea Arcangeli]

On Wed, May 16, 2001 at 11:03:27AM +0200, eccesys@topmail.de wrote:
> David,
> I am using the gcc-3.0 snapshot of 14.5.2001 from codesourcery (i686 binary).
> I have now tried to mimic CPU=386 behaviour (patch posted yesterday night)
> and it compiles (just sound fails), by exchanging y and n in
> CONFIG_RWSEM_GENERIC_SPINLOCK and CONFIG_RWSEM_XCHGADD_ALGORITHM.
> 
> Thanks for your patience, all listening...

can you check if the alternate rwsem compiles with gcc 3.0? I had a
report that they don't compile but I checked and that had to be a gcc
3.0 bug, and so I was waiting to hear they start to compile with latest
CVS of gcc 3.0.

	ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.5pre2aa1/00_rwsem-11

Andrea

Re: rwsem, gcc3 again

[David Howells]

Hi Andrea:

Here you go:

/usr/local/bin/gcc -D__KERNEL__ -I/inst-kernels/linux-2.4.5-pre2-aa/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=i686    -DEXPORT_SYMTAB -c sys.c
sys.c: In function `sys_gethostname':
/inst-kernels/linux-2.4.5-pre2-aa/include/asm/rwsem_xchgadd.h:51: inconsistent
operand constraints in an `asm'

I've lit fires underneath some of our gcc people, and they say it's definitely
a bug in gcc. They're currently looking at it.

David

Re: rwsem, gcc3 again

[Andrea Arcangeli]

On Wed, May 16, 2001 at 02:52:04PM +0100, David Howells wrote:
> 
> Hi Andrea:
> 
> Here you go:
> 
> /usr/local/bin/gcc -D__KERNEL__ -I/inst-kernels/linux-2.4.5-pre2-aa/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=i686    -DEXPORT_SYMTAB -c sys.c
> sys.c: In function `sys_gethostname':
> /inst-kernels/linux-2.4.5-pre2-aa/include/asm/rwsem_xchgadd.h:51: inconsistent
> operand constraints in an `asm'
> 
> I've lit fires underneath some of our gcc people, and they say it's definitely
> a bug in gcc. They're currently looking at it.

Ok, I hope it will be fixed soon ;), thanks for checking.

Andrea

Re: rwsem, gcc3 again

[mirabilos]

Andrea,
I doubt that it applies against -ac and I have only very few hard disk space,
so please don't beat me I could not try... (I tried the second-to-last but
it didn't apply either)
But 2.4.3-ac7 works very fine with your older patch.
As noticed, I now solved by CONFIG_RWSEM_GENERIC_SPINLOCK=y (as in i386)
by hand on i686.

Sorry
-mirabilos
-- 
by telnet

rwsem, gcc3 again

[mirabilos]

Hi,
I have got that patch with "movl %2,%%edx" and removing the tmp
and still cannot compile with the same error message I posted yesterday.
The problem seems to be that, with or without "inline", it seems to
put a reference into main.o of arch/i386/boot/compressed.
So I cannot test -ac9 :(

If anyone could find a (final or at least until gcc is fixed temporarily)
solution please please could either post or mail me?
Please no Cc: as I am on the list.

-mirabilos
-- 
by telnet

Re: rwsem, gcc3 again

[Tom Leete]

mirabilos wrote:
> 
> Hi,
> I have got that patch with "movl %2,%%edx" and removing the tmp
> and still cannot compile with the same error message I posted yesterday.
> The problem seems to be that, with or without "inline", it seems to
> put a reference into main.o of arch/i386/boot/compressed.
> So I cannot test -ac9 :(
> 
> If anyone could find a (final or at least until gcc is fixed temporarily)
> solution please please could either post or mail me?
> Please no Cc: as I am on the list.
> 
> -mirabilos
> --

Hi,

Petr Vandrovic's patch works for me.
$ cat /proc/version
Linux version 2.4.5-pre1 (tleete@mercury) (gcc version 3.0 20010423
(prerelease)) #6 Tue May 15 07:13:10 EDT 2001
You don't mention the constraint changes, did you apply them too?

I posted a simpler patch which miscompiled on gcc3 and 2.95.3. Still trying
to understand why, it was Obviously Correct. It was also the cause of my
boot hangs.

Cheers,
Tom

-- 
The Daemons lurk and are dumb. -- Emerson