From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Russell King <rmk@arm.linux.org.uk>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports
Date: Tue, 26 Oct 2004 08:20:04 +1000 [thread overview]
Message-ID: <1098742804.6719.27.camel@gaston> (raw)
In-Reply-To: <1098742146.2144.200.camel@mulgrave>
On Mon, 2004-10-25 at 18:08 -0400, James Bottomley wrote:
> ia64 seems to rely on empty ports being registered. Without this, ia64
> crashes on boot with
>
> Removing wrong port: 0000000000000000 != a000000100781bd8
I send this patch to Linus already, though he may have missed it, I'll
resend.
Ben.
> James
>
> ===== drivers/serial/8250.c 1.76 vs edited =====
> --- 1.76/drivers/serial/8250.c 2004-10-22 18:31:26 -05:00
> +++ edited/drivers/serial/8250.c 2004-10-25 16:59:22 -05:00
> @@ -2001,13 +2001,6 @@
> for (i = 0; i < UART_NR; i++) {
> struct uart_8250_port *up = &serial8250_ports[i];
>
> - /* Don't register "empty" ports, setting "ops" on them
> - * makes the console driver "setup" routine to succeed,
> - * which is wrong. --BenH.
> - */
> - if (!up->port.iobase)
> - continue;
> -
> up->port.line = i;
> up->port.ops = &serial8250_pops;
> up->port.dev = dev;
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
prev parent reply other threads:[~2004-10-25 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 22:08 ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports James Bottomley
2004-10-25 22:20 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098742804.6719.27.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox