* ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports
@ 2004-10-25 22:08 James Bottomley
2004-10-25 22:20 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: James Bottomley @ 2004-10-25 22:08 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Russell King; +Cc: Linux Kernel
ia64 seems to rely on empty ports being registered. Without this, ia64
crashes on boot with
Removing wrong port: 0000000000000000 != a000000100781bd8
James
===== drivers/serial/8250.c 1.76 vs edited =====
--- 1.76/drivers/serial/8250.c 2004-10-22 18:31:26 -05:00
+++ edited/drivers/serial/8250.c 2004-10-25 16:59:22 -05:00
@@ -2001,13 +2001,6 @@
for (i = 0; i < UART_NR; i++) {
struct uart_8250_port *up = &serial8250_ports[i];
- /* Don't register "empty" ports, setting "ops" on them
- * makes the console driver "setup" routine to succeed,
- * which is wrong. --BenH.
- */
- if (!up->port.iobase)
- continue;
-
up->port.line = i;
up->port.ops = &serial8250_pops;
up->port.dev = dev;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports
2004-10-25 22:08 ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports James Bottomley
@ 2004-10-25 22:20 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2004-10-25 22:20 UTC (permalink / raw)
To: James Bottomley; +Cc: Russell King, Linux Kernel list
On Mon, 2004-10-25 at 18:08 -0400, James Bottomley wrote:
> ia64 seems to rely on empty ports being registered. Without this, ia64
> crashes on boot with
>
> Removing wrong port: 0000000000000000 != a000000100781bd8
I send this patch to Linus already, though he may have missed it, I'll
resend.
Ben.
> James
>
> ===== drivers/serial/8250.c 1.76 vs edited =====
> --- 1.76/drivers/serial/8250.c 2004-10-22 18:31:26 -05:00
> +++ edited/drivers/serial/8250.c 2004-10-25 16:59:22 -05:00
> @@ -2001,13 +2001,6 @@
> for (i = 0; i < UART_NR; i++) {
> struct uart_8250_port *up = &serial8250_ports[i];
>
> - /* Don't register "empty" ports, setting "ops" on them
> - * makes the console driver "setup" routine to succeed,
> - * which is wrong. --BenH.
> - */
> - if (!up->port.iobase)
> - continue;
> -
> up->port.line = i;
> up->port.ops = &serial8250_pops;
> up->port.dev = dev;
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-25 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-25 22:08 ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports James Bottomley
2004-10-25 22:20 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox